From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
To: paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com
Cc: kees@kernel.org, yuehaibing@huawei.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, matthewgarrett@google.com,
skhan@linuxfoundation.org, anupnewsmail@gmail.com,
tanyaagarwal25699@gmail.com
Subject: [PATCH V3] lockdown: Initialize array before use
Date: Sun, 5 Jan 2025 12:35:38 +0530 [thread overview]
Message-ID: <20250105070537.58334-1-tanyaagarwal25699@gmail.com> (raw)
From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
The static code analysis tool "Coverity Scan" pointed the following
details out for further development considerations:
CID 1486102: Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value *temp when calling
strlen.
Conclusion:
Initialize array before use in lockdown_read() to satisfy the static
analyzer.
Fixes: 000d388ed3bb ("security: Add a static lockdown policy LSM")
Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
---
V2: add Fixes tag and reword commit description
V3: use "" initialization instead of {}
Coverity Link:
https://scan7.scan.coverity.com/#/project-view/52849/11354?selectedIssue=1486102
security/lockdown/lockdown.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/lockdown/lockdown.c b/security/lockdown/lockdown.c
index f2bdbd55aa2b..cf83afa1d879 100644
--- a/security/lockdown/lockdown.c
+++ b/security/lockdown/lockdown.c
@@ -96,7 +96,7 @@ static int __init lockdown_lsm_init(void)
static ssize_t lockdown_read(struct file *filp, char __user *buf, size_t count,
loff_t *ppos)
{
- char temp[80];
+ char temp[80] = "";
int i, offset = 0;
for (i = 0; i < ARRAY_SIZE(lockdown_levels); i++) {
--
2.39.5
next reply other threads:[~2025-01-05 7:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 7:05 Tanya Agarwal [this message]
2025-01-05 10:42 ` [PATCH V3] lockdown: Initialize array before use Kuan-Wei Chiu
2025-01-05 17:48 ` [PATCH v3] " Paul Moore
2025-01-05 17:52 ` Tanya Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250105070537.58334-1-tanyaagarwal25699@gmail.com \
--to=tanyaagarwal25699@gmail.com \
--cc=anupnewsmail@gmail.com \
--cc=jmorris@namei.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=skhan@linuxfoundation.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox