From: Paul Moore <paul@paul-moore.com>
To: Tanya Agarwal <tanyaagarwal25699@gmail.com>,
jmorris@namei.org, serge@hallyn.com
Cc: kees@kernel.org, yuehaibing@huawei.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, matthewgarrett@google.com,
skhan@linuxfoundation.org, anupnewsmail@gmail.com,
tanyaagarwal25699@gmail.com
Subject: Re: [PATCH v3] lockdown: Initialize array before use
Date: Sun, 05 Jan 2025 12:48:41 -0500 [thread overview]
Message-ID: <2f7db63290c5c81513721f10a65f602e@paul-moore.com> (raw)
In-Reply-To: <20250105070537.58334-1-tanyaagarwal25699@gmail.com>
On Jan 5, 2025 Tanya Agarwal <tanyaagarwal25699@gmail.com> wrote:
>
> The static code analysis tool "Coverity Scan" pointed the following
> details out for further development considerations:
> CID 1486102: Uninitialized scalar variable (UNINIT)
> uninit_use_in_call: Using uninitialized value *temp when calling
> strlen.
>
> Conclusion:
> Initialize array before use in lockdown_read() to satisfy the static
> analyzer.
>
> Fixes: 000d388ed3bb ("security: Add a static lockdown policy LSM")
> Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
I removed the 'Fixes:' tag as the code isn't actually broken as we
discussed in previous iterations of this patch. I also edited the
subject line and commit description a bit, but otherwise this is
fine. Merged into lsm/dev.
--
paul-moore.com
next prev parent reply other threads:[~2025-01-05 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 7:05 [PATCH V3] lockdown: Initialize array before use Tanya Agarwal
2025-01-05 10:42 ` Kuan-Wei Chiu
2025-01-05 17:48 ` Paul Moore [this message]
2025-01-05 17:52 ` [PATCH v3] " Tanya Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f7db63290c5c81513721f10a65f602e@paul-moore.com \
--to=paul@paul-moore.com \
--cc=anupnewsmail@gmail.com \
--cc=jmorris@namei.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=serge@hallyn.com \
--cc=skhan@linuxfoundation.org \
--cc=tanyaagarwal25699@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox