[PATCH] lsm: use lsm_blob_alloc() in lsm_bdev_alloc()

[PATCH] lsm: use lsm_blob_alloc() in lsm_bdev_alloc()

[Paul Moore]

Convert the lsm_bdev_alloc() function to use the lsm_blob_alloc() helper
like all of the other LSM security blob allocators.

Signed-off-by: Paul Moore <paul@paul-moore.com>
---
 security/security.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/security/security.c b/security/security.c
index ad163f06bf7a..a88ebfca3224 100644
--- a/security/security.c
+++ b/security/security.c
@@ -823,16 +823,8 @@ static int lsm_msg_msg_alloc(struct msg_msg *mp)
  */
 static int lsm_bdev_alloc(struct block_device *bdev)
 {
-	if (blob_sizes.lbs_bdev == 0) {
-		bdev->bd_security = NULL;
-		return 0;
-	}
-
-	bdev->bd_security = kzalloc(blob_sizes.lbs_bdev, GFP_KERNEL);
-	if (!bdev->bd_security)
-		return -ENOMEM;
-
-	return 0;
+	return lsm_blob_alloc(&bdev->bd_security, blob_sizes.lbs_bdev,
+			      GFP_KERNEL);
 }
 
 /**
-- 
2.50.1

Re: [PATCH] lsm: use lsm_blob_alloc() in lsm_bdev_alloc()

[Casey Schaufler]

On 8/6/2025 2:25 PM, Paul Moore wrote:
> Convert the lsm_bdev_alloc() function to use the lsm_blob_alloc() helper
> like all of the other LSM security blob allocators.
>
> Signed-off-by: Paul Moore <paul@paul-moore.com>

Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>

> ---
>  security/security.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/security/security.c b/security/security.c
> index ad163f06bf7a..a88ebfca3224 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -823,16 +823,8 @@ static int lsm_msg_msg_alloc(struct msg_msg *mp)
>   */
>  static int lsm_bdev_alloc(struct block_device *bdev)
>  {
> -	if (blob_sizes.lbs_bdev == 0) {
> -		bdev->bd_security = NULL;
> -		return 0;
> -	}
> -
> -	bdev->bd_security = kzalloc(blob_sizes.lbs_bdev, GFP_KERNEL);
> -	if (!bdev->bd_security)
> -		return -ENOMEM;
> -
> -	return 0;
> +	return lsm_blob_alloc(&bdev->bd_security, blob_sizes.lbs_bdev,
> +			      GFP_KERNEL);
>  }
>  
>  /**

Re: [PATCH] lsm: use lsm_blob_alloc() in lsm_bdev_alloc()

[Serge E. Hallyn]

On Wed, Aug 06, 2025 at 05:25:53PM -0400, Paul Moore wrote:
> Convert the lsm_bdev_alloc() function to use the lsm_blob_alloc() helper
> like all of the other LSM security blob allocators.
> 
> Signed-off-by: Paul Moore <paul@paul-moore.com>

Acked-by: Serge Hallyn <serge@hallyn.com>

> ---
>  security/security.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/security/security.c b/security/security.c
> index ad163f06bf7a..a88ebfca3224 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -823,16 +823,8 @@ static int lsm_msg_msg_alloc(struct msg_msg *mp)
>   */
>  static int lsm_bdev_alloc(struct block_device *bdev)
>  {
> -	if (blob_sizes.lbs_bdev == 0) {
> -		bdev->bd_security = NULL;
> -		return 0;
> -	}
> -
> -	bdev->bd_security = kzalloc(blob_sizes.lbs_bdev, GFP_KERNEL);
> -	if (!bdev->bd_security)
> -		return -ENOMEM;
> -
> -	return 0;
> +	return lsm_blob_alloc(&bdev->bd_security, blob_sizes.lbs_bdev,
> +			      GFP_KERNEL);
>  }
>  
>  /**
> -- 
> 2.50.1
> 

Re: [PATCH] lsm: use lsm_blob_alloc() in lsm_bdev_alloc()

[Paul Moore]

On Wed, Aug 6, 2025 at 5:26 PM Paul Moore <paul@paul-moore.com> wrote:
>
> Convert the lsm_bdev_alloc() function to use the lsm_blob_alloc() helper
> like all of the other LSM security blob allocators.
>
> Signed-off-by: Paul Moore <paul@paul-moore.com>
> ---
>  security/security.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)

Normally I might let this sit a bit longer on the mailing list, but
considering how trivial this is along with a Reviewed-by and an ACK
I'm going to go ahead and merge this into lsm/dev-staging for testing
and lsm/dev once the merge window closes.

-- 
paul-moore.com

Re: [PATCH] lsm: use lsm_blob_alloc() in lsm_bdev_alloc()

[Paul Moore]

On Wed, Aug 6, 2025 at 9:49 PM Paul Moore <paul@paul-moore.com> wrote:
> On Wed, Aug 6, 2025 at 5:26 PM Paul Moore <paul@paul-moore.com> wrote:
> >
> > Convert the lsm_bdev_alloc() function to use the lsm_blob_alloc() helper
> > like all of the other LSM security blob allocators.
> >
> > Signed-off-by: Paul Moore <paul@paul-moore.com>
> > ---
> >  security/security.c | 12 ++----------
> >  1 file changed, 2 insertions(+), 10 deletions(-)
>
> Normally I might let this sit a bit longer on the mailing list, but
> considering how trivial this is along with a Reviewed-by and an ACK
> I'm going to go ahead and merge this into lsm/dev-staging for testing
> and lsm/dev once the merge window closes.

This is now in lsm/dev, thanks all.

-- 
paul-moore.com