* [PATCH v2] ima: allow users to specify the pcr index with IMA_MEASURE_PCR_IDX
@ 2026-09-04 11:09 Julian Braha
2026-09-04 20:49 ` Mimi Zohar
0 siblings, 1 reply; 2+ messages in thread
From: Julian Braha @ 2026-09-04 11:09 UTC (permalink / raw)
To: zohar, roberto.sassu, dmitry.kasatkin, paul, jmorris, serge
Cc: eric.snowberg, linux-integrity, linux-security-module,
linux-kernel, Julian Braha
The IMA_MEASURE_PCR_IDX option is currently not visible in the kconfig
frontend, so it always uses its default, 10. This means that the
'range 8 14' is dead code, and users are unable to specify the pcr index
value.
In a previous discussion, Mimi explained that users should be able to use
this config option to specify the pcr index. [1]
Let's add a prompt for users to specify the pcr index, when EXPERT is
enabled.
This dead range was found by kconfirm, a static analysis tool for Kconfig.
Link: https://lore.kernel.org/all/1feff118-4afa-4b9c-86f1-271a7a88208f@gmail.com/T/#mc4efa2491b4937eb7c9e532c29ffba516a70e662 [1]
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
Changes since v1:
- updated help text to recommend using the default of 10
v1:
https://lore.kernel.org/all/20260824162215.1572367-1-julianbraha@gmail.com/
---
security/integrity/ima/Kconfig | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
index b3a9f86809b0..72654cf797cd 100644
--- a/security/integrity/ima/Kconfig
+++ b/security/integrity/ima/Kconfig
@@ -46,12 +46,16 @@ config IMA_KEXEC
config IMA_MEASURE_PCR_IDX
int
+ prompt "PCR Index for Aggregate" if EXPERT
range 8 14
default 10
help
IMA_MEASURE_PCR_IDX determines the TPM PCR register index
that IMA uses to maintain the integrity aggregate of the
- measurement list. If unsure, use the default 10.
+ measurement list. Most attestation tooling expects PCR 10.
+
+ The default is almost always what you want. Only change this
+ if you know what you are doing.
config IMA_LSM_RULES
bool
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ima: allow users to specify the pcr index with IMA_MEASURE_PCR_IDX
2026-09-04 11:09 [PATCH v2] ima: allow users to specify the pcr index with IMA_MEASURE_PCR_IDX Julian Braha
@ 2026-09-04 20:49 ` Mimi Zohar
0 siblings, 0 replies; 2+ messages in thread
From: Mimi Zohar @ 2026-09-04 20:49 UTC (permalink / raw)
To: Julian Braha, roberto.sassu, dmitry.kasatkin, paul, jmorris,
serge
Cc: eric.snowberg, linux-integrity, linux-security-module,
linux-kernel
On Fri, 2026-09-04 at 12:09 +0100, Julian Braha wrote:
> The IMA_MEASURE_PCR_IDX option is currently not visible in the kconfig
> frontend, so it always uses its default, 10. This means that the
> 'range 8 14' is dead code, and users are unable to specify the pcr index
> value.
>
> In a previous discussion, Mimi explained that users should be able to use
> this config option to specify the pcr index. [1]
>
> Let's add a prompt for users to specify the pcr index, when EXPERT is
> enabled.
>
> This dead range was found by kconfirm, a static analysis tool for Kconfig.
>
> Link: https://lore.kernel.org/all/1feff118-4afa-4b9c-86f1-271a7a88208f@gmail.com/T/#mc4efa2491b4937eb7c9e532c29ffba516a70e662 [1]
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Thanks, Julian. The patch is now queued in the next-integrity branch.
Mimi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-04 20:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-04 11:09 [PATCH v2] ima: allow users to specify the pcr index with IMA_MEASURE_PCR_IDX Julian Braha
2026-09-04 20:49 ` Mimi Zohar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox