* [PATCH] security: keys: Fix comment of search_process_keyrings_rcu()
@ 2026-09-28 7:20 Thomas Huth
2026-09-28 7:23 ` sashiko-bot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2026-09-28 7:20 UTC (permalink / raw)
To: David Howells, Jarkko Sakkinen, Paul Moore, James Morris,
Serge E. Hallyn
Cc: keyrings, linux-security-module, linux-kernel
search_my_process_keyrings() has been renamed to search_cred_keyrings_rcu()
in commit e59428f721ee ("keys: Move the RCU locks outwards from the keyring
search functions"), but one spot has been missed in a comment.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
security/keys/process_keys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
index a63c46bb2d148..570c131d90d5c 100644
--- a/security/keys/process_keys.c
+++ b/security/keys/process_keys.c
@@ -528,7 +528,7 @@ key_ref_t search_cred_keyrings_rcu(struct keyring_search_context *ctx)
/*
* Search the process keyrings attached to the supplied cred for the first
- * matching key in the manner of search_my_process_keyrings(), but also search
+ * matching key in the manner of search_cred_keyrings_rcu(), but also search
* the keys attached to the assumed authorisation key using its credentials if
* one is available.
*
--
2.55.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] security: keys: Fix comment of search_process_keyrings_rcu()
2026-09-28 7:20 [PATCH] security: keys: Fix comment of search_process_keyrings_rcu() Thomas Huth
@ 2026-09-28 7:23 ` sashiko-bot
2026-09-28 11:58 ` Jinjie Ruan
2026-09-29 21:23 ` Jarkko Sakkinen
2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-09-28 7:23 UTC (permalink / raw)
Cc: linux-security-module
> search_my_process_keyrings() has been renamed to search_cred_keyrings_rcu()
> in commit e59428f721ee ("keys: Move the RCU locks outwards from the keyring
> search functions"), but one spot has been missed in a comment.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928072024.91664-1-thuth@redhat.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] security: keys: Fix comment of search_process_keyrings_rcu()
2026-09-28 7:20 [PATCH] security: keys: Fix comment of search_process_keyrings_rcu() Thomas Huth
2026-09-28 7:23 ` sashiko-bot
@ 2026-09-28 11:58 ` Jinjie Ruan
2026-09-29 21:23 ` Jarkko Sakkinen
2 siblings, 0 replies; 4+ messages in thread
From: Jinjie Ruan @ 2026-09-28 11:58 UTC (permalink / raw)
To: Thomas Huth, David Howells, Jarkko Sakkinen, Paul Moore,
James Morris, Serge E. Hallyn
Cc: keyrings, linux-security-module, linux-kernel
在 2026/9/28 15:20, Thomas Huth 写道:
> search_my_process_keyrings() has been renamed to search_cred_keyrings_rcu()
> in commit e59428f721ee ("keys: Move the RCU locks outwards from the keyring
> search functions"), but one spot has been missed in a comment.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> security/keys/process_keys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
> index a63c46bb2d148..570c131d90d5c 100644
> --- a/security/keys/process_keys.c
> +++ b/security/keys/process_keys.c
> @@ -528,7 +528,7 @@ key_ref_t search_cred_keyrings_rcu(struct keyring_search_context *ctx)
>
> /*
> * Search the process keyrings attached to the supplied cred for the first
> - * matching key in the manner of search_my_process_keyrings(), but also search
> + * matching key in the manner of search_cred_keyrings_rcu(), but also search
> * the keys attached to the assumed authorisation key using its credentials if
Reviewed-by: Jinjie Ruan <ruanjinjie@huawei.com>
> * one is available.
> *
--
Best regards,
Jinjie
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] security: keys: Fix comment of search_process_keyrings_rcu()
2026-09-28 7:20 [PATCH] security: keys: Fix comment of search_process_keyrings_rcu() Thomas Huth
2026-09-28 7:23 ` sashiko-bot
2026-09-28 11:58 ` Jinjie Ruan
@ 2026-09-29 21:23 ` Jarkko Sakkinen
2 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2026-09-29 21:23 UTC (permalink / raw)
To: Thomas Huth
Cc: David Howells, Paul Moore, James Morris, Serge E. Hallyn,
keyrings, linux-security-module, linux-kernel
On Mon, Sep 28, 2026 at 09:20:23AM +0200, Thomas Huth wrote:
> search_my_process_keyrings() has been renamed to search_cred_keyrings_rcu()
> in commit e59428f721ee ("keys: Move the RCU locks outwards from the keyring
> search functions"), but one spot has been missed in a comment.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> security/keys/process_keys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
> index a63c46bb2d148..570c131d90d5c 100644
> --- a/security/keys/process_keys.c
> +++ b/security/keys/process_keys.c
> @@ -528,7 +528,7 @@ key_ref_t search_cred_keyrings_rcu(struct keyring_search_context *ctx)
>
> /*
> * Search the process keyrings attached to the supplied cred for the first
> - * matching key in the manner of search_my_process_keyrings(), but also search
> + * matching key in the manner of search_cred_keyrings_rcu(), but also search
> * the keys attached to the assumed authorisation key using its credentials if
> * one is available.
> *
> --
> 2.55.0
>
Thanks.
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Br, Jarkko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-29 21:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-28 7:20 [PATCH] security: keys: Fix comment of search_process_keyrings_rcu() Thomas Huth
2026-09-28 7:23 ` sashiko-bot
2026-09-28 11:58 ` Jinjie Ruan
2026-09-29 21:23 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox