* [PATCH -next] security: Remove unused declaration cap_mmap_file()
@ 2025-06-24 1:41 Yue Haibing
2025-06-24 12:27 ` sergeh
2025-06-24 23:32 ` [PATCH] " Paul Moore
0 siblings, 2 replies; 5+ messages in thread
From: Yue Haibing @ 2025-06-24 1:41 UTC (permalink / raw)
To: paul, jmorris, serge, casey
Cc: linux-security-module, linux-kernel, yuehaibing
Commit 3f4f1f8a1ab7 ("capabilities: remove cap_mmap_file()")
removed the implementation but leave declaration.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
include/linux/security.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/security.h b/include/linux/security.h
index dba349629229..e8d9f6069f0c 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -193,8 +193,6 @@ int cap_inode_getsecurity(struct mnt_idmap *idmap,
struct inode *inode, const char *name, void **buffer,
bool alloc);
extern int cap_mmap_addr(unsigned long addr);
-extern int cap_mmap_file(struct file *file, unsigned long reqprot,
- unsigned long prot, unsigned long flags);
extern int cap_task_fix_setuid(struct cred *new, const struct cred *old, int flags);
extern int cap_task_prctl(int option, unsigned long arg2, unsigned long arg3,
unsigned long arg4, unsigned long arg5);
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH -next] security: Remove unused declaration cap_mmap_file()
2025-06-24 1:41 [PATCH -next] security: Remove unused declaration cap_mmap_file() Yue Haibing
@ 2025-06-24 12:27 ` sergeh
2025-06-24 15:48 ` Paul Moore
2025-06-24 23:32 ` [PATCH] " Paul Moore
1 sibling, 1 reply; 5+ messages in thread
From: sergeh @ 2025-06-24 12:27 UTC (permalink / raw)
To: Yue Haibing
Cc: paul, jmorris, serge, casey, linux-security-module, linux-kernel
On Tue, Jun 24, 2025 at 09:41:08AM +0800, Yue Haibing wrote:
> Commit 3f4f1f8a1ab7 ("capabilities: remove cap_mmap_file()")
> removed the implementation but leave declaration.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Hm, how did I not catch that? Thanks.
Reviewed-by: Serge Hallyn <serge@hallyn.com>
> ---
> include/linux/security.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/security.h b/include/linux/security.h
> index dba349629229..e8d9f6069f0c 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -193,8 +193,6 @@ int cap_inode_getsecurity(struct mnt_idmap *idmap,
> struct inode *inode, const char *name, void **buffer,
> bool alloc);
> extern int cap_mmap_addr(unsigned long addr);
> -extern int cap_mmap_file(struct file *file, unsigned long reqprot,
> - unsigned long prot, unsigned long flags);
> extern int cap_task_fix_setuid(struct cred *new, const struct cred *old, int flags);
> extern int cap_task_prctl(int option, unsigned long arg2, unsigned long arg3,
> unsigned long arg4, unsigned long arg5);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] security: Remove unused declaration cap_mmap_file()
2025-06-24 12:27 ` sergeh
@ 2025-06-24 15:48 ` Paul Moore
2025-06-24 20:46 ` Serge E. Hallyn
0 siblings, 1 reply; 5+ messages in thread
From: Paul Moore @ 2025-06-24 15:48 UTC (permalink / raw)
To: sergeh
Cc: Yue Haibing, jmorris, serge, casey, linux-security-module,
linux-kernel
On Tue, Jun 24, 2025 at 8:27 AM <sergeh@kernel.org> wrote:
> On Tue, Jun 24, 2025 at 09:41:08AM +0800, Yue Haibing wrote:
> > Commit 3f4f1f8a1ab7 ("capabilities: remove cap_mmap_file()")
> > removed the implementation but leave declaration.
> >
> > Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>
> Hm, how did I not catch that? Thanks.
At least you weren't the idiot who wrote the original patch ;)
I'll grab this for the LSM tree in a bit unless you want to take it.
> Reviewed-by: Serge Hallyn <serge@hallyn.com>
>
> > ---
> > include/linux/security.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/include/linux/security.h b/include/linux/security.h
> > index dba349629229..e8d9f6069f0c 100644
> > --- a/include/linux/security.h
> > +++ b/include/linux/security.h
> > @@ -193,8 +193,6 @@ int cap_inode_getsecurity(struct mnt_idmap *idmap,
> > struct inode *inode, const char *name, void **buffer,
> > bool alloc);
> > extern int cap_mmap_addr(unsigned long addr);
> > -extern int cap_mmap_file(struct file *file, unsigned long reqprot,
> > - unsigned long prot, unsigned long flags);
> > extern int cap_task_fix_setuid(struct cred *new, const struct cred *old, int flags);
> > extern int cap_task_prctl(int option, unsigned long arg2, unsigned long arg3,
> > unsigned long arg4, unsigned long arg5);
> > --
> > 2.34.1
--
paul-moore.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] security: Remove unused declaration cap_mmap_file()
2025-06-24 15:48 ` Paul Moore
@ 2025-06-24 20:46 ` Serge E. Hallyn
0 siblings, 0 replies; 5+ messages in thread
From: Serge E. Hallyn @ 2025-06-24 20:46 UTC (permalink / raw)
To: Paul Moore
Cc: sergeh, Yue Haibing, jmorris, serge, casey, linux-security-module,
linux-kernel
On Tue, Jun 24, 2025 at 11:48:10AM -0400, Paul Moore wrote:
> On Tue, Jun 24, 2025 at 8:27 AM <sergeh@kernel.org> wrote:
> > On Tue, Jun 24, 2025 at 09:41:08AM +0800, Yue Haibing wrote:
> > > Commit 3f4f1f8a1ab7 ("capabilities: remove cap_mmap_file()")
> > > removed the implementation but leave declaration.
> > >
> > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> >
> > Hm, how did I not catch that? Thanks.
>
> At least you weren't the idiot who wrote the original patch ;)
>
> I'll grab this for the LSM tree in a bit unless you want to take it.
Either way - go ahead :) Thanks.
> > Reviewed-by: Serge Hallyn <serge@hallyn.com>
> >
> > > ---
> > > include/linux/security.h | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/include/linux/security.h b/include/linux/security.h
> > > index dba349629229..e8d9f6069f0c 100644
> > > --- a/include/linux/security.h
> > > +++ b/include/linux/security.h
> > > @@ -193,8 +193,6 @@ int cap_inode_getsecurity(struct mnt_idmap *idmap,
> > > struct inode *inode, const char *name, void **buffer,
> > > bool alloc);
> > > extern int cap_mmap_addr(unsigned long addr);
> > > -extern int cap_mmap_file(struct file *file, unsigned long reqprot,
> > > - unsigned long prot, unsigned long flags);
> > > extern int cap_task_fix_setuid(struct cred *new, const struct cred *old, int flags);
> > > extern int cap_task_prctl(int option, unsigned long arg2, unsigned long arg3,
> > > unsigned long arg4, unsigned long arg5);
> > > --
> > > 2.34.1
>
> --
> paul-moore.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] security: Remove unused declaration cap_mmap_file()
2025-06-24 1:41 [PATCH -next] security: Remove unused declaration cap_mmap_file() Yue Haibing
2025-06-24 12:27 ` sergeh
@ 2025-06-24 23:32 ` Paul Moore
1 sibling, 0 replies; 5+ messages in thread
From: Paul Moore @ 2025-06-24 23:32 UTC (permalink / raw)
To: Yue Haibing, jmorris, serge, casey
Cc: linux-security-module, linux-kernel, yuehaibing
On Jun 23, 2025 Yue Haibing <yuehaibing@huawei.com> wrote:
>
> Commit 3f4f1f8a1ab7 ("capabilities: remove cap_mmap_file()")
> removed the implementation but leave declaration.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> include/linux/security.h | 2 --
> 1 file changed, 2 deletions(-)
Merged into lsm/dev, thanks for noticing this and submitting a patch.
--
paul-moore.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-24 23:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-24 1:41 [PATCH -next] security: Remove unused declaration cap_mmap_file() Yue Haibing
2025-06-24 12:27 ` sergeh
2025-06-24 15:48 ` Paul Moore
2025-06-24 20:46 ` Serge E. Hallyn
2025-06-24 23:32 ` [PATCH] " Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox