Linux Security Modules development
 help / color / mirror / Atom feed
From: Nicolas Bouchinet <nicolas.bouchinet@oss.cyber.gouv.fr>
To: Kalevi Kolttonen <kalevi@kolttonen.fi>
Cc: linux-security-module@vger.kernel.org,
	 Cai Xinchen <caixinchen1@huawei.com>,
	Xiujianfeng <xiujianfeng@huaweicloud.com>,
	 Xiujianfeng <xiujianfeng@huawei.com>
Subject: Re: [PATCH] lockdown: remove useless decrement operation
Date: Tue, 5 May 2026 11:20:07 +0200	[thread overview]
Message-ID: <afmxC6U2p5hITUOY@archlinux> (raw)
In-Reply-To: <20260501174448.47154-1-kalevi@kolttonen.fi>

Hi Kalevi, 

Thanks for your contribution,

While it is true that the len variable decrement is not used anywhere
and that removing it would be cleaner, this patch does not otherwise
bring any direct benefits.

Ideally we should go through the full Lockdown code to clean it, I'll
include it with Cai's one[1] when a more consequent patch will be ready.
I'll thus keep those somewhere until then.

I have a two week holiday starting this Friday and will thus not be
available until the 26th of may. Xiu, and Cai, if you want to work on it
I'll gladly review the patchset.

Best regards,

Nicolas

[1]: https://lore.kernel.org/all/20260119091226.3195309-1-caixinchen1@huawei.com/

  reply	other threads:[~2026-05-05  9:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01 17:44 [PATCH] lockdown: remove useless decrement operation Kalevi Kolttonen
2026-05-05  9:20 ` Nicolas Bouchinet [this message]
2026-05-05  9:51 ` Nicolas Bouchinet
2026-05-07  9:38   ` Xiu Jianfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afmxC6U2p5hITUOY@archlinux \
    --to=nicolas.bouchinet@oss.cyber.gouv.fr \
    --cc=caixinchen1@huawei.com \
    --cc=kalevi@kolttonen.fi \
    --cc=linux-security-module@vger.kernel.org \
    --cc=xiujianfeng@huawei.com \
    --cc=xiujianfeng@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox