From: Xiu Jianfeng <xiujianfeng@huawei.com>
To: Nicolas Bouchinet <nicolas.bouchinet@oss.cyber.gouv.fr>,
Kalevi Kolttonen <kalevi@kolttonen.fi>
Cc: <linux-security-module@vger.kernel.org>, <xiujianfeng@huaweicloud.com>
Subject: Re: [PATCH] lockdown: remove useless decrement operation
Date: Thu, 7 May 2026 17:38:11 +0800 [thread overview]
Message-ID: <d3393689-ef1a-4c79-b6db-9d4fb1c9f5ae@huawei.com> (raw)
In-Reply-To: <afm9F_neup5eiD5z@archlinux>
On 5/5/2026 5:51 PM, Nicolas Bouchinet wrote:
> Hi Kalevi, thanks for your contribution,
>
> While it is true the len variable decrementing is not used anywhere and
> that it would be cleaner to remove it, ideally we should go through a
> more in depth Lockdown code cleaning.
> I'll include it with Cai's one[1] when a more consequent patch will be
> ready. I'll thus keep it somewhere with the patch until then.
>
> I have a two week holiday starting this Friday and will thus not be available
> until the 26th of may. Xiu, and Cai, if you want to work on it I'll gladly
> review the patch set.
Hi Nicolas,
Have a nice holiday!
I'm in favor of a cleanup where it makes sense, but I don't see any
code that specifically needs it at the moment. Feel free to point out
any areas of concern when you have a moment.
>
> [1]: https://lore.kernel.org/all/20260119091226.3195309-1-caixinchen1@huawei.com/
>
> Best regards,
>
> Nicolas
prev parent reply other threads:[~2026-05-07 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 17:44 [PATCH] lockdown: remove useless decrement operation Kalevi Kolttonen
2026-05-05 9:20 ` Nicolas Bouchinet
2026-05-05 9:51 ` Nicolas Bouchinet
2026-05-07 9:38 ` Xiu Jianfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3393689-ef1a-4c79-b6db-9d4fb1c9f5ae@huawei.com \
--to=xiujianfeng@huawei.com \
--cc=kalevi@kolttonen.fi \
--cc=linux-security-module@vger.kernel.org \
--cc=nicolas.bouchinet@oss.cyber.gouv.fr \
--cc=xiujianfeng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox