From: James Morris <jmorris@namei.org>
To: Paul Moore <paul@paul-moore.com>
Cc: selinux@vger.kernel.org, linux-security-module@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH] lsm,selinux: pass the family information along with xfrm flow
Date: Wed, 30 Sep 2020 09:09:20 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.21.2009300909150.6592@namei.org> (raw)
In-Reply-To: <160141647786.7997.5490924406329369782.stgit@sifl>
On Tue, 29 Sep 2020, Paul Moore wrote:
> As pointed out by Herbert in a recent related patch, the LSM hooks
> should pass the address family in addition to the xfrm flow as the
> family information is needed to safely access the flow.
>
> While this is not technically a problem for the current LSM/SELinux
> code as it only accesses fields common to all address families, we
> should still pass the address family so that the LSM hook isn't
> inherently flawed. An alternate solution could be to simply pass
> the LSM secid instead of flow, but this introduces the problem of
> the LSM hook callers sending the wrong secid which would be much
> worse.
>
> Reported-by: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Paul Moore <paul@paul-moore.com>
I'm not keen on adding a parameter which nobody is using. Perhaps a note
in the header instead?
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2020-09-29 23:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 21:54 [RFC PATCH] lsm,selinux: pass the family information along with xfrm flow Paul Moore
2020-09-29 22:38 ` Casey Schaufler
2020-09-29 23:09 ` James Morris [this message]
2020-09-30 10:14 ` Herbert Xu
2020-09-30 13:44 ` Paul Moore
2020-10-28 2:09 ` Paul Moore
2020-10-28 5:27 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.2009300909150.6592@namei.org \
--to=jmorris@namei.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox