From: James Morris <jmorris@namei.org>
To: Paul Moore <paul@paul-moore.com>
Cc: linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH] lsm,selinux: pass the family information along with xfrm flow
Date: Wed, 28 Oct 2020 16:27:48 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LRH.2.21.2010281627250.25689@namei.org> (raw)
In-Reply-To: <CAHC9VhSq6stUdMSS5MXKDas5RHnrJiKSDU60CbKYe04x2DvymQ@mail.gmail.com>
On Tue, 27 Oct 2020, Paul Moore wrote:
> On Wed, Sep 30, 2020 at 9:44 AM Paul Moore <paul@paul-moore.com> wrote:
> > On Tue, Sep 29, 2020 at 7:09 PM James Morris <jmorris@namei.org> wrote:
> > > I'm not keen on adding a parameter which nobody is using. Perhaps a note
> > > in the header instead?
> >
> > On Wed, Sep 30, 2020 at 6:14 AM Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > > Please at least change to the struct flowi to flowi_common if we're
> > > not adding a family field.
> >
> > It did feel a bit weird adding a (currently) unused parameter, so I
> > can understand the concern, I just worry that a comment in the code
> > will be easily overlooked. I also thought about passing a pointer to
> > the nested flowi_common struct, but it doesn't appear that this is
> > done anywhere else in the stack so it felt wrong to do it here.
>
> With the merge window behind us, where do stand on this? I see the
> ACK from Casey and some grumbling about adding an unused parameter
> (which is a valid argument, I just feel the alternative is worse), but
> I haven't seen any serious NACKs.
>
> Any objections or other strong feelings to me merging this via the
> selinux/next branch?
Yes, we should not add unused parameters to functions.
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2020-10-28 21:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 21:54 [RFC PATCH] lsm,selinux: pass the family information along with xfrm flow Paul Moore
2020-09-29 22:38 ` Casey Schaufler
2020-09-29 23:09 ` James Morris
2020-09-30 10:14 ` Herbert Xu
2020-09-30 13:44 ` Paul Moore
2020-10-28 2:09 ` Paul Moore
2020-10-28 5:27 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.2010281627250.25689@namei.org \
--to=jmorris@namei.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox