* Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY [not found] <20201117150856.GA12240@mail.hallyn.com> @ 2020-11-20 3:16 ` James Morris 2020-11-20 3:19 ` James Morris ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: James Morris @ 2020-11-20 3:16 UTC (permalink / raw) To: Serge E. Hallyn Cc: lkml, Hervé Guillemet, Andrew G. Morgan, Casey Schaufler, linux-security-module [-- Attachment #1: Type: text/plain, Size: 2294 bytes --] [Adding LSM list] On Tue, 17 Nov 2020, Serge E. Hallyn wrote: > Namespaced file capabilities were introduced in 8db6c34f1dbc . > When userspace reads an xattr for a namespaced capability, a > virtualized representation of it is returned if the caller is > in a user namespace owned by the capability's owning rootid. > The function which performs this virtualization was not hooked > up if CONFIG_SECURITY=n. Therefore in that case the original > xattr was shown instead of the virtualized one. > > To test this using libcap-bin (*1), > > $ v=$(mktemp) > $ unshare -Ur setcap cap_sys_admin-eip $v > $ unshare -Ur setcap -v cap_sys_admin-eip $v > /tmp/tmp.lSiIFRvt8Y: OK > > "setcap -v" verifies the values instead of setting them, and > will check whether the rootid value is set. Therefore, with > this bug un-fixed, and with CONFIG_SECURITY=n, setcap -v will > fail: > > $ v=$(mktemp) > $ unshare -Ur setcap cap_sys_admin=eip $v > $ unshare -Ur setcap -v cap_sys_admin=eip $v > nsowner[got=1000, want=0],/tmp/tmp.HHDiOOl9fY differs in [] > > Fix this bug by calling cap_inode_getsecurity() in > security_inode_getsecurity() instead of returning > -EOPNOTSUPP, when CONFIG_SECURITY=n. > > *1 - note, if libcap is too old for getcap to have the '-n' > option, then use verify-caps instead. > > Signed-off-by: Serge Hallyn <serge@hallyn.com> > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1593431 > Cc: Hervé Guillemet <herve@guillemet.org> > Cc: Andrew G. Morgan <morgan@kernel.org> > Cc: Casey Schaufler <casey@schaufler-ca.com> > --- > include/linux/security.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/security.h b/include/linux/security.h > index bc2725491560..39642626a707 100644 > --- a/include/linux/security.h > +++ b/include/linux/security.h > @@ -869,7 +869,7 @@ static inline int security_inode_killpriv(struct dentry *dentry) > > static inline int security_inode_getsecurity(struct inode *inode, const char *name, void **buffer, bool alloc) > { > - return -EOPNOTSUPP; > + return cap_inode_getsecurity(inode, name, buffer, alloc); > } > > static inline int security_inode_setsecurity(struct inode *inode, const char *name, const void *value, size_t size, int flags) > -- James Morris <jmorris@namei.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY [not found] <20201117150856.GA12240@mail.hallyn.com> 2020-11-20 3:16 ` [PATCH] fix namespaced fscaps when !CONFIG_SECURITY James Morris @ 2020-11-20 3:19 ` James Morris [not found] ` <CALQRfL5UzUt0YkKDAguETmdXM7qsPC9sGmsgutQ-P2cymPte-w@mail.gmail.com> [not found] ` <CALQRfL6q8ppuWi3ygY6iqh6SX9pnkVnvJDynTD61K2wUqerahg@mail.gmail.com> 3 siblings, 0 replies; 5+ messages in thread From: James Morris @ 2020-11-20 3:19 UTC (permalink / raw) To: Serge E. Hallyn Cc: lkml, Hervé Guillemet, Andrew G. Morgan, Casey Schaufler, linux-security-module On Tue, 17 Nov 2020, Serge E. Hallyn wrote: > *1 - note, if libcap is too old for getcap to have the '-n' > option, then use verify-caps instead. > > Signed-off-by: Serge Hallyn <serge@hallyn.com> > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1593431 "Perf fails to compile with python 3.7" Wrong bug ID? -- James Morris <jmorris@namei.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CALQRfL5UzUt0YkKDAguETmdXM7qsPC9sGmsgutQ-P2cymPte-w@mail.gmail.com>]
* Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY [not found] ` <CALQRfL5UzUt0YkKDAguETmdXM7qsPC9sGmsgutQ-P2cymPte-w@mail.gmail.com> @ 2020-11-20 3:19 ` James Morris 2020-11-20 5:03 ` Andrew G. Morgan 0 siblings, 1 reply; 5+ messages in thread From: James Morris @ 2020-11-20 3:19 UTC (permalink / raw) To: Andrew G. Morgan Cc: Serge E. Hallyn, lkml, Hervé Guillemet, Casey Schaufler, linux-security-module On Tue, 17 Nov 2020, Andrew G. Morgan wrote: > Signed-off-by: Andrew G. Morgan <morgan@kernel.org> This should be Acked-by or Reviewed-by, unless this is your patch, or it came via your tree. -- James Morris <jmorris@namei.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY 2020-11-20 3:19 ` James Morris @ 2020-11-20 5:03 ` Andrew G. Morgan 0 siblings, 0 replies; 5+ messages in thread From: Andrew G. Morgan @ 2020-11-20 5:03 UTC (permalink / raw) To: James Morris Cc: Serge E. Hallyn, lkml, Hervé Guillemet, Casey Schaufler, LSM List Reviewed-by: Andrew G. Morgan <morgan@kernel.org> Works for me too. On Thu, Nov 19, 2020 at 7:20 PM James Morris <jmorris@namei.org> wrote: > > On Tue, 17 Nov 2020, Andrew G. Morgan wrote: > > > Signed-off-by: Andrew G. Morgan <morgan@kernel.org> > > This should be Acked-by or Reviewed-by, unless this is your patch, or it > came via your tree. > > > -- > James Morris > <jmorris@namei.org> > ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CALQRfL6q8ppuWi3ygY6iqh6SX9pnkVnvJDynTD61K2wUqerahg@mail.gmail.com>]
[parent not found: <20201129211542.GA5227@mail.hallyn.com>]
[parent not found: <alpine.LRH.2.21.2012011358200.28022@namei.org>]
[parent not found: <CALQRfL6OQKuBqbUoC7_yH7W4qabYSamRYUqjM-HE1gj2r_CaHQ@mail.gmail.com>]
* Re: [PATCH] fix namespaced fscaps when !CONFIG_SECURITY [not found] ` <CALQRfL6OQKuBqbUoC7_yH7W4qabYSamRYUqjM-HE1gj2r_CaHQ@mail.gmail.com> @ 2020-12-05 0:27 ` James Morris 0 siblings, 0 replies; 5+ messages in thread From: James Morris @ 2020-12-05 0:27 UTC (permalink / raw) To: Andrew G. Morgan Cc: Serge E. Hallyn, lkml, Hervé Guillemet, Casey Schaufler, linux-security-module On Fri, 4 Dec 2020, Andrew G. Morgan wrote: > The correct bug reference for this patch is: > > https://bugzilla.kernel.org/show_bug.cgi?id=209689 > > Reviewed-by: Andrew G. Morgan <morgan@kernel.org> Thanks. Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git fixes-5.10 and next-testing -- James Morris <jmorris@namei.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-05 0:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201117150856.GA12240@mail.hallyn.com>
2020-11-20 3:16 ` [PATCH] fix namespaced fscaps when !CONFIG_SECURITY James Morris
2020-11-20 3:19 ` James Morris
[not found] ` <CALQRfL5UzUt0YkKDAguETmdXM7qsPC9sGmsgutQ-P2cymPte-w@mail.gmail.com>
2020-11-20 3:19 ` James Morris
2020-11-20 5:03 ` Andrew G. Morgan
[not found] ` <CALQRfL6q8ppuWi3ygY6iqh6SX9pnkVnvJDynTD61K2wUqerahg@mail.gmail.com>
[not found] ` <20201129211542.GA5227@mail.hallyn.com>
[not found] ` <alpine.LRH.2.21.2012011358200.28022@namei.org>
[not found] ` <CALQRfL6OQKuBqbUoC7_yH7W4qabYSamRYUqjM-HE1gj2r_CaHQ@mail.gmail.com>
2020-12-05 0:27 ` James Morris
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox