Linux Security Modules development
 help / color / mirror / Atom feed
* [PATCH] capability: remove non-kernel-doc comments
@ 2026-07-23 16:52 Randy Dunlap
  2026-07-23 17:08 ` Paul Moore
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2026-07-23 16:52 UTC (permalink / raw)
  To: linux-security-module
  Cc: Randy Dunlap, Paul Moore, James Morris, Serge E. Hallyn

Convert 2 "/**" comments to use plain C "/*" comment style to avoid
kernel-doc warnings:

Warning: include/uapi/linux/capability.h:114 expecting prototype for
 POSIX(). Prototype was for CAP_CHOWN() instead
Warning: include/uapi/linux/capability.h:175 expecting prototype for
 Linux(). Prototype was for CAP_SETPCAP() instead

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Paul Moore <paul@paul-moore.com>
Cc: James Morris <jmorris@namei.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>

 include/uapi/linux/capability.h |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

--- linux-next-20260722.orig/include/uapi/linux/capability.h
+++ linux-next-20260722/include/uapi/linux/capability.h
@@ -104,9 +104,9 @@ struct vfs_ns_cap_data {
 #endif
 
 
-/**
- ** POSIX-draft defined capabilities.
- **/
+/*
+ * POSIX-draft defined capabilities.
+ */
 
 /* In a system with the [_POSIX_CHOWN_RESTRICTED] option defined, this
    overrides the restriction of changing file ownership and group
@@ -159,9 +159,9 @@ struct vfs_ns_cap_data {
 #define CAP_SETUID           7
 
 
-/**
- ** Linux-specific capabilities
- **/
+/*
+ * Linux-specific capabilities
+ */
 
 /* Without VFS support for capabilities:
  *   Transfer any capability in your permitted set to any pid,

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] capability: remove non-kernel-doc comments
  2026-07-23 16:52 [PATCH] capability: remove non-kernel-doc comments Randy Dunlap
@ 2026-07-23 17:08 ` Paul Moore
  2026-07-23 20:05   ` sergeh
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Moore @ 2026-07-23 17:08 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: linux-security-module, James Morris, Serge E. Hallyn

On Thu, Jul 23, 2026 at 12:52 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Convert 2 "/**" comments to use plain C "/*" comment style to avoid
> kernel-doc warnings:
>
> Warning: include/uapi/linux/capability.h:114 expecting prototype for
>  POSIX(). Prototype was for CAP_CHOWN() instead
> Warning: include/uapi/linux/capability.h:175 expecting prototype for
>  Linux(). Prototype was for CAP_SETPCAP() instead
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: James Morris <jmorris@namei.org>
> Cc: "Serge E. Hallyn" <serge@hallyn.com>
>
>  include/uapi/linux/capability.h |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

I'm assuming Serge will take this via the capabilities tree, but I can
always take it via the LSM tree if he prefers.

Reviewed-by: Paul Moore <paul@paul-moore.com>

-- 
paul-moore.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] capability: remove non-kernel-doc comments
  2026-07-23 17:08 ` Paul Moore
@ 2026-07-23 20:05   ` sergeh
  0 siblings, 0 replies; 3+ messages in thread
From: sergeh @ 2026-07-23 20:05 UTC (permalink / raw)
  To: Paul Moore
  Cc: Randy Dunlap, linux-security-module, James Morris,
	Serge E. Hallyn

On Thu, Jul 23, 2026 at 01:08:38PM -0400, Paul Moore wrote:
> On Thu, Jul 23, 2026 at 12:52 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > Convert 2 "/**" comments to use plain C "/*" comment style to avoid
> > kernel-doc warnings:
> >
> > Warning: include/uapi/linux/capability.h:114 expecting prototype for
> >  POSIX(). Prototype was for CAP_CHOWN() instead
> > Warning: include/uapi/linux/capability.h:175 expecting prototype for
> >  Linux(). Prototype was for CAP_SETPCAP() instead
> >
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > ---
> > Cc: Paul Moore <paul@paul-moore.com>
> > Cc: James Morris <jmorris@namei.org>
> > Cc: "Serge E. Hallyn" <serge@hallyn.com>
> >
> >  include/uapi/linux/capability.h |   12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> I'm assuming Serge will take this via the capabilities tree, but I can
> always take it via the LSM tree if he prefers.

Yup, I'll take it, thanks.

> Reviewed-by: Paul Moore <paul@paul-moore.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-23 20:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 16:52 [PATCH] capability: remove non-kernel-doc comments Randy Dunlap
2026-07-23 17:08 ` Paul Moore
2026-07-23 20:05   ` sergeh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox