Linux Security Modules development
 help / color / mirror / Atom feed
* [PATCH] security: update lockdown_reasons[] reference
@ 2026-11-12 17:37 Baruch Siach
  2026-11-12 17:40 ` sashiko-bot
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Baruch Siach @ 2026-11-12 17:37 UTC (permalink / raw)
  To: Paul Moore, James Morris, Serge E. Hallyn
  Cc: linux-security-module, Nicolas Bouchinet, Xiu Jianfeng,
	Baruch Siach

Commit 59438b46471ae6 ("security,lockdown,selinux: implement SELinux
lockdown") moved lockdown_reasons[] from security/lockdown/lockdown.c to
security/security.c. Update the documentation comment to match.

Fixes: 59438b46471ae6 ("security,lockdown,selinux: implement SELinux lockdown")
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 include/linux/security.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/security.h b/include/linux/security.h
index 40831fab5470..2782ee404f95 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -124,7 +124,7 @@ enum lsm_integrity_type {
  * so.
  *
  * If you add to this, remember to extend lockdown_reasons in
- * security/lockdown/lockdown.c.
+ * security/security.c.
  */
 enum lockdown_reason {
 	LOCKDOWN_NONE,
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] security: update lockdown_reasons[] reference
  2026-11-12 17:37 [PATCH] security: update lockdown_reasons[] reference Baruch Siach
@ 2026-11-12 17:40 ` sashiko-bot
  2026-11-13  1:42 ` Cai Xinchen
  2026-11-13  1:50 ` Xiu Jianfeng
  2 siblings, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-11-12 17:40 UTC (permalink / raw)
  Cc: linux-security-module

> Commit 59438b46471ae6 ("security,lockdown,selinux: implement SELinux
> lockdown") moved lockdown_reasons[] from security/lockdown/lockdown.c to
> security/security.c. Update the documentation comment to match.
> 
> Fixes: 59438b46471ae6 ("security,lockdown,selinux: implement SELinux lockdown")
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/3283a389cc21862ab98eb891436568fc1d23b869.1794505077.git.baruch@tkos.co.il?part=1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] security: update lockdown_reasons[] reference
  2026-11-12 17:37 [PATCH] security: update lockdown_reasons[] reference Baruch Siach
  2026-11-12 17:40 ` sashiko-bot
@ 2026-11-13  1:42 ` Cai Xinchen
  2026-11-13  1:50 ` Xiu Jianfeng
  2 siblings, 0 replies; 5+ messages in thread
From: Cai Xinchen @ 2026-11-13  1:42 UTC (permalink / raw)
  To: Baruch Siach, Paul Moore, James Morris, Serge E. Hallyn
  Cc: linux-security-module, Nicolas Bouchinet, Xiu Jianfeng

Hello, Barush

lockdown_reasons[] is only used by the lockdown LSM after the audit data 
was removed from lsm_audit. I have sent a patch [1] to move 
lockdown_reasons back to security/lockdown/lockdown.c. Of course, the 
final decision will be made by the maintainers, whether to move it back 
to lockdown.c or keep it in security.h with only the comments modified.

[1] 
https://lore.kernel.org/all/20261110132818.2231593-6-caixinchen1@huawei.com/

Best regards.

Cai

On 11/13/2026 1:37 AM, Baruch Siach wrote:
> Commit 59438b46471ae6 ("security,lockdown,selinux: implement SELinux
> lockdown") moved lockdown_reasons[] from security/lockdown/lockdown.c to
> security/security.c. Update the documentation comment to match.
>
> Fixes: 59438b46471ae6 ("security,lockdown,selinux: implement SELinux lockdown")
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>   include/linux/security.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/security.h b/include/linux/security.h
> index 40831fab5470..2782ee404f95 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -124,7 +124,7 @@ enum lsm_integrity_type {
>    * so.
>    *
>    * If you add to this, remember to extend lockdown_reasons in
> - * security/lockdown/lockdown.c.
> + * security/security.c.
>    */
>   enum lockdown_reason {
>   	LOCKDOWN_NONE,

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] security: update lockdown_reasons[] reference
  2026-11-12 17:37 [PATCH] security: update lockdown_reasons[] reference Baruch Siach
  2026-11-12 17:40 ` sashiko-bot
  2026-11-13  1:42 ` Cai Xinchen
@ 2026-11-13  1:50 ` Xiu Jianfeng
  2026-11-16 10:36   ` Nicolas Bouchinet
  2 siblings, 1 reply; 5+ messages in thread
From: Xiu Jianfeng @ 2026-11-13  1:50 UTC (permalink / raw)
  To: Baruch Siach, Paul Moore, James Morris, Serge E. Hallyn
  Cc: linux-security-module, Nicolas Bouchinet

On 11/13/2026 1:37 AM, Baruch Siach wrote:
> Commit 59438b46471ae6 ("security,lockdown,selinux: implement SELinux
> lockdown") moved lockdown_reasons[] from security/lockdown/lockdown.c to
> security/security.c. Update the documentation comment to match.

Hi Baruch,

Thanks for the patch.

However, Cai already has a patch under review that moves
lockdown_reasons[] back to security/lockdown/lockdown.c, and once it
gets merged, this issue will no longer exist.

You can check the discussion/patch here:
https://lore.kernel.org/all/20261110132818.2231593-6-caixinchen1@huawei.com/

> 
> Fixes: 59438b46471ae6 ("security,lockdown,selinux: implement SELinux lockdown")
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>   include/linux/security.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/security.h b/include/linux/security.h
> index 40831fab5470..2782ee404f95 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -124,7 +124,7 @@ enum lsm_integrity_type {
>    * so.
>    *
>    * If you add to this, remember to extend lockdown_reasons in
> - * security/lockdown/lockdown.c.
> + * security/security.c.
>    */
>   enum lockdown_reason {
>   	LOCKDOWN_NONE,


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] security: update lockdown_reasons[] reference
  2026-11-13  1:50 ` Xiu Jianfeng
@ 2026-11-16 10:36   ` Nicolas Bouchinet
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Bouchinet @ 2026-11-16 10:36 UTC (permalink / raw)
  To: Xiu Jianfeng
  Cc: Baruch Siach, Paul Moore, James Morris, Serge E. Hallyn,
	linux-security-module

On Fri, Nov 13, 2026 at 09:50:18AM +0800, Xiu Jianfeng wrote:
> On 11/13/2026 1:37 AM, Baruch Siach wrote:
> > Commit 59438b46471ae6 ("security,lockdown,selinux: implement SELinux
> > lockdown") moved lockdown_reasons[] from security/lockdown/lockdown.c to
> > security/security.c. Update the documentation comment to match.
> 
> Hi Baruch,
> 
> Thanks for the patch.
> 
> However, Cai already has a patch under review that moves
> lockdown_reasons[] back to security/lockdown/lockdown.c, and once it
> gets merged, this issue will no longer exist.

Indeed, we will go through Cai's contribution for this.

Best regards,

Nicolas

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-16 10:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-12 17:37 [PATCH] security: update lockdown_reasons[] reference Baruch Siach
2026-11-12 17:40 ` sashiko-bot
2026-11-13  1:42 ` Cai Xinchen
2026-11-13  1:50 ` Xiu Jianfeng
2026-11-16 10:36   ` Nicolas Bouchinet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox