From: Paul Moore <paul@paul-moore.com>
To: Bill Roberts <bill.roberts@arm.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: casey@schaufler-ca.com, Bill Roberts <bill.roberts@arm.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security: clarify task_prctl hook documentation
Date: Thu, 02 Jul 2026 14:59:22 -0400 [thread overview]
Message-ID: <e1bdf10ce11733a11975523b23f79215@paul-moore.com> (raw)
In-Reply-To: <20260615200325.260057-1-bill.roberts@arm.com>
On Jun 15, 2026 Bill Roberts <bill.roberts@arm.com> wrote:
>
> The task_prctl hook comment incorrectly described the hook as checking
> whether a prctl operation is allowed. In reality, the hook exists for
> LSMs to handle LSM-specific prctl operations.
>
> Update the function description and kernel-doc comment to reflect the
> actual behavior. The old wording appears to have been copied from other
> permission-check hooks despite differing semantics.
>
> Signed-off-by: Bill Roberts <bill.roberts@arm.com>
> Acked-by: Casey Schaufler <casey@schaufler-ca.com>
> Reviewed-by: Serge Hallyn <serge@hallyn.com>
> ---
> security/security.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Good catch, thanks! Merged into lsm/dev.
--
paul-moore.com
prev parent reply other threads:[~2026-07-02 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 20:03 [PATCH] security: clarify task_prctl hook documentation Bill Roberts
2026-06-16 16:07 ` Casey Schaufler
2026-06-16 17:14 ` Serge E. Hallyn
2026-07-02 18:59 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1bdf10ce11733a11975523b23f79215@paul-moore.com \
--to=paul@paul-moore.com \
--cc=bill.roberts@arm.com \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox