From: Takashi Iwai <tiwai@suse.de>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Javier Martinez Canillas <javierm@redhat.com>,
linux-efi <linux-efi@vger.kernel.org>, Joey Lee <jlee@suse.com>,
linux-security-module <linux-security-module@vger.kernel.org>
Subject: Re: [PATCH] efi: Suppress spurious "Couldn't get size" error
Date: Mon, 17 Feb 2020 17:10:20 +0100 [thread overview]
Message-ID: <s5hk14lfb4j.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAKv+Gu_9AqVnhwUUOGyL1HMUYgemp6SD2O5CJjy2vKpeuP4eOA@mail.gmail.com>
On Mon, 17 Feb 2020 17:06:57 +0100,
Ard Biesheuvel wrote:
>
> On Mon, 17 Feb 2020 at 16:45, Takashi Iwai <tiwai@suse.de> wrote:
> >
> > The current efi code emits the error message like
> > Couldn't get size: 0x800000000000000e
> > on various Dell and other machines. Although the whole problem is the
> > buggy firmware, showing this as an error level is rather annoying, as
> > the error message appears over the boot splash. Basically this is the
> > result of missing entry and we have no explicit way to fix it for such
> > a firmware problem, the error message may be suppressed.
> >
> > This patch changes the error print condition and suppresses the error
> > message if status is EFI_NOT_FOUND. It's a partial patch from the
> > more comprehensive one Joey Lee submitted in the past.
> >
> > Link: https://lore.kernel.org/linux-efi/20190322103350.27764-2-jlee@suse.com/
> > Cc: Joey Lee <jlee@suse.com>
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
> Hello Takashi,
>
> Javier sent a more comprehensive fix for this today. The problem is
> not buggy firmware, but buggy kernel :-)
> (the code assumes that all systems boot via shim, and that certain EFI
> variables are therefore guaranteed to exist, which is not the case)
>
> https://lore.kernel.org/linux-efi/CAKv+Gu-a5Bo9i=K55pa3jEXRq-u5JYVGp1jFEE=UY5B=6eUkRQ@mail.gmail.com
Awesome, then please scratch mine.
Thanks!
Takashi
prev parent reply other threads:[~2020-02-17 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 15:45 [PATCH] efi: Suppress spurious "Couldn't get size" error Takashi Iwai
2020-02-17 16:06 ` Ard Biesheuvel
2020-02-17 16:10 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk14lfb4j.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=ard.biesheuvel@linaro.org \
--cc=javierm@redhat.com \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox