From: "Chris Doré" <cdore@connecttech.com>
To: linux-serial <linux-serial@vger.kernel.org>
Subject: RE: Adding new driver - looking for suggestions
Date: Wed, 11 Jul 2007 10:20:03 -0400 [thread overview]
Message-ID: <004901c7c3c6$92b2c9c0$7a4b82ce@connecttech.local> (raw)
In-Reply-To: <469417A6.24982.128022FD@Frantisek.Rysanek.post.cz>
On July 10, 2007 5:35 PM, Frantisek Rysanek wrote:
>
> As far as patching the vanilla kernel is concerned:
> You seem to suggest an addition of rather proprietary data (members)
> to the neatly generic struct uart_port. I'd suggest adding something
> like
>
> void* priv; // device-specific driver private data
I agree, I'm not a fan of the current implementation. I'd like to massage
what we have into something more acceptable.
> to the generic struct uart_port of the vanilla kernel, which you
> could then use to hook your own private data struct, regardless of
> whether the rest of your driver lives in 8250_pci.c or in a stand-
> alone module. This is the way it's done in a number of other generic
> device structs (or maybe the more modern way is to use a nested
> struct with "parent struct decoding").
Thanks for the ideas.
Chris Doré
-
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-07-11 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 21:35 Adding new driver - looking for suggestions Frantisek Rysanek
2007-07-11 14:20 ` Chris Doré [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-09 17:37 Chris Doré
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004901c7c3c6$92b2c9c0$7a4b82ce@connecttech.local' \
--to=cdore@connecttech.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox