* [PATCH 13/15] serial: sirfsoc: remove unnecessary platform_set_drvdata()
@ 2013-05-07 8:06 Jingoo Han
2013-05-07 8:11 ` Barry Song
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 8:06 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'
Cc: 'Jiri Slaby', linux-serial, Jingoo Han, Barry Song,
'Rong Wang'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/tty/serial/sirfsoc_uart.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/sirfsoc_uart.c b/drivers/tty/serial/sirfsoc_uart.c
index 03465b6..f256440 100644
--- a/drivers/tty/serial/sirfsoc_uart.c
+++ b/drivers/tty/serial/sirfsoc_uart.c
@@ -716,7 +716,6 @@ port_err:
clk_disable_unprepare(sirfport->clk);
clk_put(sirfport->clk);
clk_err:
- platform_set_drvdata(pdev, NULL);
if (sirfport->hw_flow_ctrl)
pinctrl_put(sirfport->p);
err:
@@ -727,7 +726,7 @@ static int sirfsoc_uart_remove(struct platform_device *pdev)
{
struct sirfsoc_uart_port *sirfport = platform_get_drvdata(pdev);
struct uart_port *port = &sirfport->port;
- platform_set_drvdata(pdev, NULL);
+
if (sirfport->hw_flow_ctrl)
pinctrl_put(sirfport->p);
clk_disable_unprepare(sirfport->clk);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 13/15] serial: sirfsoc: remove unnecessary platform_set_drvdata()
2013-05-07 8:06 [PATCH 13/15] serial: sirfsoc: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 8:11 ` Barry Song
0 siblings, 0 replies; 2+ messages in thread
From: Barry Song @ 2013-05-07 8:11 UTC (permalink / raw)
To: Jingoo Han
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, Barry Song,
Rong Wang, DL-SHA-WorkGroupLinux
2013/5/7 Jingoo Han <jg1.han@samsung.com>
>
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Barry Song <baohua.song@csr.com>
> ---
> drivers/tty/serial/sirfsoc_uart.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/sirfsoc_uart.c
> b/drivers/tty/serial/sirfsoc_uart.c
> index 03465b6..f256440 100644
> --- a/drivers/tty/serial/sirfsoc_uart.c
> +++ b/drivers/tty/serial/sirfsoc_uart.c
> @@ -716,7 +716,6 @@ port_err:
> clk_disable_unprepare(sirfport->clk);
> clk_put(sirfport->clk);
> clk_err:
> - platform_set_drvdata(pdev, NULL);
> if (sirfport->hw_flow_ctrl)
> pinctrl_put(sirfport->p);
> err:
> @@ -727,7 +726,7 @@ static int sirfsoc_uart_remove(struct platform_device
> *pdev)
> {
> struct sirfsoc_uart_port *sirfport = platform_get_drvdata(pdev);
> struct uart_port *port = &sirfport->port;
> - platform_set_drvdata(pdev, NULL);
> +
> if (sirfport->hw_flow_ctrl)
> pinctrl_put(sirfport->p);
> clk_disable_unprepare(sirfport->clk);
> --
> 1.7.2.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 8:06 [PATCH 13/15] serial: sirfsoc: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 8:11 ` Barry Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox