Re: [PATCH 1/2] Bluetooth: hci_bcm: Remove platform_device support

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 22-01-18 12:33, Andy Shevchenko wrote:
> On Mon, 2018-01-22 at 12:27 +0100, Hans de Goede wrote:
>> On 22-01-18 10:42, Andy Shevchenko wrote:
>>> On Mon, 2018-01-22 at 09:23 +0100, Hans de Goede wrote:
>>>> On 22-01-18 03:24, Marcel Holtmann wrote:
> 
>>>> Andy, I see that you added support for bcm bluetooth over a tty
>>>> using
>>>> platform_data instead of ACPI enumeration. Can you change the code
>>>> instantiating the device to instead instantiate a serdev, so that
>>>> we
>>>> kill the platform device support in hci_bcm.c and so that users
>>>> don't
>>>> need to do a btattach, but instead the kernel will do the attach
>>>> itself
>>>> and things will just work ?
>>>
>>> I'm sorry, I can't do this soon, other more priority tasks in a
>>> pocket.
>>>
>>> The instantiation of the driver is happened in
>>> arch/x86/platform/intel-
>>> mid/device_libs/platform_bt.c
>>>
>>> I would help with review of any patches till I would able to look at
>>> it
>>> myself.
>>
>> If I manage to come up with patches do you have hardware and time to
>> test?
> 
> Yes and I would find half an hour for sure.

That is great, thank you, but ...

>> First point of order to get this working as serdev I think is to
>> modify drivers/tty/serdev/core.c a and then the
>> serdev_controller_add()
>> function to somehow recognize the serial port in question, so
>> something akin to the of_serdev_register_devices(ctrl) /
>> acpi_serdev_register_devices(ctrl) functions for platform_devs,
>> assuming
>> the tty-parent-dev on the Edison SOM is a platform_dev ?
> 
> tty parent is PCI device there.
> 
>> Anyways it looks like this will be really hard to do without access
>> to the hardware.
> 
> I can do a BAT.

Right, sorry I was not clear, when I was talking about hardware
access I was not (not only) referring to testing.

The problem is that to figure out how to hook all this together
will require poking around on the hardware, looking in sysfs, finding
some id we can use in a pci_serdev_register_devices() to add to
drivers/tty/serdev/core.c so that it only turns the serial port on
the Edison into a serdev and not somewhere else, etc.

But thinking about this more, I too have higher priority items on
my TODO list, so as much as I would like to see this cleaned up,
lets shelf this for now until you have time to look into this.

When you do find time, if you've any questions I'm happy to help.

Regards,

Hans


p.s.

I will send out a v2 of the patch-set with the patches swapped
as Marcel requested, but this patch (2/2 in the new set) is really
just for future reference until this Edison issue is resolved.