From: Marcel Holtmann <marcel@holtmann.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Gustavo F. Padovan" <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Bluez mailing list <linux-bluetooth@vger.kernel.org>,
linux-serial@vger.kernel.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH 2/2] Bluetooth: hci_bcm: Close serdev on failure to set power on bcm_open()
Date: Mon, 22 Jan 2018 03:20:41 +0100 [thread overview]
Message-ID: <52263D7A-47F4-482C-98AA-74094CBCD768@holtmann.org> (raw)
In-Reply-To: <20180121214645.15004-2-hdegoede@redhat.com>
Hi Hans,
> Commit 8bfa7e1e03ac ("Bluetooth: hci_bcm: Handle errors properly")
> introduced error checking for the bcm_gpio_set_power() call in bcm_open()
> but the error-path it introduces does not properly call
> serdev_device_close() to undo the earlier serdev_device_open(), this
> commit fixes this.
>
> Cc: Lukas Wunner <lukas@wunner.de>
> Fixes: 8bfa7e1e03ac ("Bluetooth: hci_bcm: Handle errors properly")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/bluetooth/hci_bcm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
can I get this as 1/2 so I can apply it right away.
Regards
Marcel
next prev parent reply other threads:[~2018-01-22 2:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-21 21:46 [PATCH 1/2] Bluetooth: hci_bcm: Remove platform_device support Hans de Goede
2018-01-21 21:46 ` [PATCH 2/2] Bluetooth: hci_bcm: Close serdev on failure to set power on bcm_open() Hans de Goede
2018-01-22 2:20 ` Marcel Holtmann [this message]
2018-01-22 2:24 ` [PATCH 1/2] Bluetooth: hci_bcm: Remove platform_device support Marcel Holtmann
2018-01-22 8:23 ` Hans de Goede
2018-01-22 9:42 ` Andy Shevchenko
[not found] ` <1516614127.7000.1152.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-01-22 11:27 ` Hans de Goede
2018-01-22 11:33 ` Andy Shevchenko
2018-01-22 11:49 ` Hans de Goede
[not found] ` <0cae9024-887a-45f7-7710-1684f9c0e54e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-01-22 12:01 ` Marcel Holtmann
2018-01-22 12:15 ` Andy Shevchenko
2018-01-23 23:49 ` Ferry Toth
2018-01-22 19:57 ` Marcel Holtmann
2018-01-22 20:56 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52263D7A-47F4-482C-98AA-74094CBCD768@holtmann.org \
--to=marcel@holtmann.org \
--cc=gustavo@padovan.org \
--cc=hdegoede@redhat.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox