From: Richard Genoud <richard.genoud@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-serial@vger.kernel.org
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Peter Hurley <peter@hurleysoftware.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
tglx@linutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty/serial: atmel: use port->name as name in request_irq()
Date: Fri, 27 Apr 2018 12:31:52 +0200 [thread overview]
Message-ID: <0dbf4a4c-71d4-6456-67b9-d4d202acffb7@sorico.fr> (raw)
In-Reply-To: <20180426151222.6vw67lwqmu6ffgnw@linutronix.de>
Hi Sebastian,
On 26/04/2018 17:12, Sebastian Andrzej Siewior wrote:
> On 2018-04-26 17:06:25 [+0200], To linux-serial@vger.kernel.org wrote:
>> It seems not to happen in v4.1.51 but it happens in v4.9 and v4.17-rc2
>> so if it broke accidentally it was not recently.
>
> This is what I used to check:
>
> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> --- a/drivers/tty/tty_io.c
> +++ b/drivers/tty/tty_io.c
> @@ -170,7 +170,7 @@ void free_tty_struct(struct tty_struct *tty)
> put_device(tty->dev);
> kfree(tty->write_buf);
> tty->magic = 0xDEADDEAD;
> - kfree(tty);
> + strcpy(tty->name, "GONE");
> }
>
> static inline struct tty_struct *file_tty(struct file *file)
>
> If this is unknown and a bisect is requested, please let me know.
Indeed, this will be appreciated.
I'm quite curious to find the commit that led to this.
Thanks !
>
> Sebastian
>
Richard
next prev parent reply other threads:[~2018-04-27 10:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 15:06 [PATCH] tty/serial: atmel: use port->name as name in request_irq() Sebastian Andrzej Siewior
2018-04-26 15:12 ` Sebastian Andrzej Siewior
2018-04-27 10:31 ` Richard Genoud [this message]
2018-05-02 19:16 ` Sebastian Andrzej Siewior
2018-05-03 12:36 ` Richard Genoud
2018-05-03 12:44 ` Sebastian Andrzej Siewior
2018-05-03 13:34 ` Richard Genoud
2018-05-03 15:12 ` Richard Genoud
2018-05-04 6:35 ` Richard Genoud
2018-05-04 8:14 ` [PATCH v2] " Sebastian Andrzej Siewior
2018-05-04 10:28 ` Richard Genoud
2018-05-04 20:23 ` Rob Herring
2018-05-07 17:11 ` [PATCH v3] " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dbf4a4c-71d4-6456-67b9-d4d202acffb7@sorico.fr \
--to=richard.genoud@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox