From: Richard Genoud <richard.genoud@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Rob Herring <robh@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Peter Hurley <peter@hurleysoftware.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
tglx@linutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty/serial: atmel: use port->name as name in request_irq()
Date: Thu, 3 May 2018 14:36:03 +0200 [thread overview]
Message-ID: <4f3f6e7c-2806-1749-1523-72d5c8eb8229@sorico.fr> (raw)
In-Reply-To: <20180502191632.tgda4g5v3rhncx7c@linutronix.de>
On 02/05/2018 21:16, Sebastian Andrzej Siewior wrote:
> On 2018-04-27 12:31:52 [+0200], Richard Genoud wrote:
>> Hi Sebastian,
> Hi,
>
>>> If this is unknown and a bisect is requested, please let me know.
>> Indeed, this will be appreciated.
>> I'm quite curious to find the commit that led to this.
>
> commit 761ed4a94582ab291aa24dcbea4e01e8936488c8
> Author: Rob Herring <robh@kernel.org>
> Date: Mon Aug 22 17:39:10 2016 -0500
>
> tty: serial_core: convert uart_close to use tty_port_close
>
> tty_port_close handles much of the common parts of tty close. Convert
> uart_close to use it and move the serial_core specific parts into
> tty_port.shutdown function. This will be needed to use tty_port functions
> directly from in kernel clients.
>
> This change causes ops->stop_rx() to be called after uart_wait_until_sent()
> is called which I think should be fine. Otherwise, the sequence of the
> close should be the same.
>
> Cc: Peter Hurley <peter@hurleysoftware.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Acked-by: Alan Cox <alan@linux.intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> The thread starts at
> https://www.spinics.net/lists/linux-serial/msg30070.html
> http://lkml.kernel.org/r/20180426150625.q5tqcb7fzchvkb5d@linutronix.de
Thanks for this hunting session !
Could resend your patch with Fixes: in the commit message ?
BTW, I didn't manage to reproduce the behavior you describe, could you
give me your .config and describe a little more how you manage to
trigger this bug ?
(do you use the console on serial debug ? which board ? )
Thanks !
next prev parent reply other threads:[~2018-05-03 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 15:06 [PATCH] tty/serial: atmel: use port->name as name in request_irq() Sebastian Andrzej Siewior
2018-04-26 15:12 ` Sebastian Andrzej Siewior
2018-04-27 10:31 ` Richard Genoud
2018-05-02 19:16 ` Sebastian Andrzej Siewior
2018-05-03 12:36 ` Richard Genoud [this message]
2018-05-03 12:44 ` Sebastian Andrzej Siewior
2018-05-03 13:34 ` Richard Genoud
2018-05-03 15:12 ` Richard Genoud
2018-05-04 6:35 ` Richard Genoud
2018-05-04 8:14 ` [PATCH v2] " Sebastian Andrzej Siewior
2018-05-04 10:28 ` Richard Genoud
2018-05-04 20:23 ` Rob Herring
2018-05-07 17:11 ` [PATCH v3] " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f3f6e7c-2806-1749-1523-72d5c8eb8229@sorico.fr \
--to=richard.genoud@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox