From: Jun Chen <jun.d.chen@intel.com>
To: alan@linux.intel.com
Cc: linux-serial@vger.kernel.org, russ.gorby@intel.com,
chuansheng.liu@intel.com, chao.bi@intel.com
Subject: [PATCH] serial: ifx6x60: del_timer_sync must not be called in interrupt context.
Date: Fri, 19 Oct 2012 09:51:30 -0400 [thread overview]
Message-ID: <1350654690.4332.12.camel@chenjun-workstation> (raw)
This patch make use of del_timer instead of del_timer_sync in the
interrupt context.
The spi_timer function don't use any resources that may release after
running del_timer,
so using the del_timer is also safe and enough in this context.
Signed-off-by: Chen Jun <jun.d.chen@intel.com>
---
drivers/tty/serial/ifx6x60.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
index 5b9bc19..769396a 100644
--- a/drivers/tty/serial/ifx6x60.c
+++ b/drivers/tty/serial/ifx6x60.c
@@ -826,7 +826,7 @@ error_ret:
static void ifx_spi_handle_srdy(struct ifx_spi_device *ifx_dev)
{
if (test_bit(IFX_SPI_STATE_TIMER_PENDING, &ifx_dev->flags)) {
- del_timer_sync(&ifx_dev->spi_timer);
+ del_timer(&ifx_dev->spi_timer);
clear_bit(IFX_SPI_STATE_TIMER_PENDING, &ifx_dev->flags);
}
--
1.7.4.1
next reply other threads:[~2012-10-19 5:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 13:51 Jun Chen [this message]
2012-10-19 6:47 ` [PATCH] serial: ifx6x60: del_timer_sync must not be called in interrupt context Liu, Chuansheng
2012-10-19 9:54 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350654690.4332.12.camel@chenjun-workstation \
--to=jun.d.chen@intel.com \
--cc=alan@linux.intel.com \
--cc=chao.bi@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=linux-serial@vger.kernel.org \
--cc=russ.gorby@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox