* [PATCH] serial: ifx6x60: del_timer_sync must not be called in interrupt context.
@ 2012-10-19 13:51 Jun Chen
2012-10-19 6:47 ` Liu, Chuansheng
2012-10-19 9:54 ` Alan Cox
0 siblings, 2 replies; 3+ messages in thread
From: Jun Chen @ 2012-10-19 13:51 UTC (permalink / raw)
To: alan; +Cc: linux-serial, russ.gorby, chuansheng.liu, chao.bi
This patch make use of del_timer instead of del_timer_sync in the
interrupt context.
The spi_timer function don't use any resources that may release after
running del_timer,
so using the del_timer is also safe and enough in this context.
Signed-off-by: Chen Jun <jun.d.chen@intel.com>
---
drivers/tty/serial/ifx6x60.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
index 5b9bc19..769396a 100644
--- a/drivers/tty/serial/ifx6x60.c
+++ b/drivers/tty/serial/ifx6x60.c
@@ -826,7 +826,7 @@ error_ret:
static void ifx_spi_handle_srdy(struct ifx_spi_device *ifx_dev)
{
if (test_bit(IFX_SPI_STATE_TIMER_PENDING, &ifx_dev->flags)) {
- del_timer_sync(&ifx_dev->spi_timer);
+ del_timer(&ifx_dev->spi_timer);
clear_bit(IFX_SPI_STATE_TIMER_PENDING, &ifx_dev->flags);
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] serial: ifx6x60: del_timer_sync must not be called in interrupt context.
2012-10-19 13:51 [PATCH] serial: ifx6x60: del_timer_sync must not be called in interrupt context Jun Chen
@ 2012-10-19 6:47 ` Liu, Chuansheng
2012-10-19 9:54 ` Alan Cox
1 sibling, 0 replies; 3+ messages in thread
From: Liu, Chuansheng @ 2012-10-19 6:47 UTC (permalink / raw)
To: Chen, Jun D, alan@linux.intel.com
Cc: linux-serial@vger.kernel.org, Gorby, Russ, Bi, Chao
> -----Original Message-----
> From: Chen, Jun D
> Sent: Friday, October 19, 2012 9:52 PM
> To: alan@linux.intel.com
> Cc: linux-serial@vger.kernel.org; Gorby, Russ; Liu, Chuansheng; Bi, Chao
> Subject: [PATCH] serial: ifx6x60: del_timer_sync must not be called in interrupt
> context.
>
>
> This patch make use of del_timer instead of del_timer_sync in the
> interrupt context.
> The spi_timer function don't use any resources that may release after
> running del_timer,
> so using the del_timer is also safe and enough in this context.
>
> Signed-off-by: Chen Jun <jun.d.chen@intel.com>
It has been tested on our medfield platform.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: ifx6x60: del_timer_sync must not be called in interrupt context.
2012-10-19 13:51 [PATCH] serial: ifx6x60: del_timer_sync must not be called in interrupt context Jun Chen
2012-10-19 6:47 ` Liu, Chuansheng
@ 2012-10-19 9:54 ` Alan Cox
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2012-10-19 9:54 UTC (permalink / raw)
To: Jun Chen; +Cc: alan, linux-serial, russ.gorby, chuansheng.liu, chao.bi
On Fri, 19 Oct 2012 09:51:30 -0400
Jun Chen <jun.d.chen@intel.com> wrote:
>
> This patch make use of del_timer instead of del_timer_sync in the
> interrupt context.
> The spi_timer function don't use any resources that may release after
> running del_timer,
> so using the del_timer is also safe and enough in this context.
>
> Signed-off-by: Chen Jun <jun.d.chen@intel.com>
Acked-by: Alan Cox <alan@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-19 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-19 13:51 [PATCH] serial: ifx6x60: del_timer_sync must not be called in interrupt context Jun Chen
2012-10-19 6:47 ` Liu, Chuansheng
2012-10-19 9:54 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox