Linux Serial subsystem development
 help / color / mirror / Atom feed
* [PATCH] serial: imx: Fix build warning when CONFIG_LPAE=y
@ 2013-09-20 23:47 Fabio Estevam
  2013-09-20 23:58 ` Olof Johansson
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-09-20 23:47 UTC (permalink / raw)
  To: gregkh; +Cc: khilman, olof, linux-serial, Fabio Estevam

From: Fabio Estevam <fabio.estevam@freescale.com>

Building multi_v7_defconfig with CONFIG_LPAE=y leads to the following build 
warning:

drivers/tty/serial/imx.c: In function 'imx_verify_port':
drivers/tty/serial/imx.c:1542:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Fix the casting to get rid of the warning.

Reported-by: Kevin Hilman <khilman@linaro.org>
Reported-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/tty/serial/imx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index a0ebbc9..dd5e583 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1539,7 +1539,7 @@ imx_verify_port(struct uart_port *port, struct serial_struct *ser)
 		ret = -EINVAL;
 	if (sport->port.uartclk / 16 != ser->baud_base)
 		ret = -EINVAL;
-	if ((void *)sport->port.mapbase != ser->iomem_base)
+	if (sport->port.mapbase != (unsigned long)ser->iomem_base)
 		ret = -EINVAL;
 	if (sport->port.iobase != ser->port)
 		ret = -EINVAL;
-- 
1.8.1.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] serial: imx: Fix build warning when CONFIG_LPAE=y
  2013-09-20 23:47 [PATCH] serial: imx: Fix build warning when CONFIG_LPAE=y Fabio Estevam
@ 2013-09-20 23:58 ` Olof Johansson
  0 siblings, 0 replies; 2+ messages in thread
From: Olof Johansson @ 2013-09-20 23:58 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Greg Kroah-Hartman, Kevin Hilman, linux-serial, Fabio Estevam

On Fri, Sep 20, 2013 at 4:47 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Building multi_v7_defconfig with CONFIG_LPAE=y leads to the following build
> warning:
>
> drivers/tty/serial/imx.c: In function 'imx_verify_port':
> drivers/tty/serial/imx.c:1542:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> Fix the casting to get rid of the warning.
>
> Reported-by: Kevin Hilman <khilman@linaro.org>
> Reported-by: Olof Johansson <olof@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Already fixed by:

http://marc.info/?l=linux-kernel&m=137896012701204&w=2

(But sitting in Greg's queue due to the merge window).


-Olof

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-20 23:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-20 23:47 [PATCH] serial: imx: Fix build warning when CONFIG_LPAE=y Fabio Estevam
2013-09-20 23:58 ` Olof Johansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox