From: Tomasz Figa <tomasz.figa@gmail.com>
To: "José Miguel Gonçalves" <jose.goncalves@inov.pt>
Cc: t.figa@samsung.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, heiko@sntech.de,
s.nawrocki@samsung.com
Subject: Re: [PATCH v2] serial: samsung: add support for manual RTS setting
Date: Wed, 18 Sep 2013 19:17:30 +0200 [thread overview]
Message-ID: <1396773.mUrBgMlKxN@flatron> (raw)
In-Reply-To: <1379519569-7266-1-git-send-email-jose.goncalves@inov.pt>
Hi José,
On Wednesday 18 of September 2013 16:52:49 José Miguel Gonçalves wrote:
> The Samsung serial driver currently does not support setting the
> RTS pin with an ioctl(TIOCMSET) call. This patch adds this support.
>
> Changes in v2:
> - Preserve the RTS pin's manual setting in set_termios() also when
> enabling CRTSCTS.
>
> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
> ---
> drivers/tty/serial/samsung.c | 20 +++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
Looks good.
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-09-18 17:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 15:52 [PATCH v2] serial: samsung: add support for manual RTS setting José Miguel Gonçalves
2013-09-18 17:17 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396773.mUrBgMlKxN@flatron \
--to=tomasz.figa@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jose.goncalves@inov.pt \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox