* [PATCH v1] serial: mctrl_gpio: Add missing module license
@ 2016-02-23 14:54 Romain Izard
2016-02-23 15:21 ` Fabio Estevam
2016-02-29 8:49 ` Uwe Kleine-König
0 siblings, 2 replies; 4+ messages in thread
From: Romain Izard @ 2016-02-23 14:54 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jiri Slaby, linux-serial, linux-kernel, Romain Izard
As the mctrl_gpio driver can be built as a module, it needs to have its
license specified with MODULE_LICENSE. Otherwise, it cannot access
required symbols exported through EXPORT_SYMBOL_GPL.
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
drivers/tty/serial/serial_mctrl_gpio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
index 226ad23b136c..02147361eaa9 100644
--- a/drivers/tty/serial/serial_mctrl_gpio.c
+++ b/drivers/tty/serial/serial_mctrl_gpio.c
@@ -20,6 +20,7 @@
#include <linux/gpio/consumer.h>
#include <linux/termios.h>
#include <linux/serial_core.h>
+#include <linux/module.h>
#include "serial_mctrl_gpio.h"
@@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios)
}
}
EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
+
+MODULE_LICENSE("GPL");
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] serial: mctrl_gpio: Add missing module license
2016-02-23 14:54 [PATCH v1] serial: mctrl_gpio: Add missing module license Romain Izard
@ 2016-02-23 15:21 ` Fabio Estevam
2016-02-23 16:05 ` Romain Izard
2016-02-29 8:49 ` Uwe Kleine-König
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2016-02-23 15:21 UTC (permalink / raw)
To: Romain Izard
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial@vger.kernel.org,
linux-kernel
On Tue, Feb 23, 2016 at 11:54 AM, Romain Izard
<romain.izard.pro@gmail.com> wrote:
> As the mctrl_gpio driver can be built as a module, it needs to have its
> license specified with MODULE_LICENSE. Otherwise, it cannot access
> required symbols exported through EXPORT_SYMBOL_GPL.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
> drivers/tty/serial/serial_mctrl_gpio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
> index 226ad23b136c..02147361eaa9 100644
> --- a/drivers/tty/serial/serial_mctrl_gpio.c
> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
> @@ -20,6 +20,7 @@
> #include <linux/gpio/consumer.h>
> #include <linux/termios.h>
> #include <linux/serial_core.h>
> +#include <linux/module.h>
>
> #include "serial_mctrl_gpio.h"
>
> @@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios)
> }
> }
> EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
> +
> +MODULE_LICENSE("GPL");
Shouldn't it be "GPL v2" instead to match the licensing text in the
top of the file?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] serial: mctrl_gpio: Add missing module license
2016-02-23 15:21 ` Fabio Estevam
@ 2016-02-23 16:05 ` Romain Izard
0 siblings, 0 replies; 4+ messages in thread
From: Romain Izard @ 2016-02-23 16:05 UTC (permalink / raw)
To: Fabio Estevam
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial@vger.kernel.org,
linux-kernel
2016-02-23 16:21 GMT+01:00 Fabio Estevam <festevam@gmail.com>:
> On Tue, Feb 23, 2016 at 11:54 AM, Romain Izard
> <romain.izard.pro@gmail.com> wrote:
>> As the mctrl_gpio driver can be built as a module, it needs to have its
>> license specified with MODULE_LICENSE. Otherwise, it cannot access
>> required symbols exported through EXPORT_SYMBOL_GPL.
>>
>> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
>> ---
>> drivers/tty/serial/serial_mctrl_gpio.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
>> index 226ad23b136c..02147361eaa9 100644
>> --- a/drivers/tty/serial/serial_mctrl_gpio.c
>> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
>> @@ -20,6 +20,7 @@
>> #include <linux/gpio/consumer.h>
>> #include <linux/termios.h>
>> #include <linux/serial_core.h>
>> +#include <linux/module.h>
>>
>> #include "serial_mctrl_gpio.h"
>>
>> @@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios)
>> }
>> }
>> EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
>> +
>> +MODULE_LICENSE("GPL");
>
> Shouldn't it be "GPL v2" instead to match the licensing text in the
> top of the file?
According to include/linux/module.h, "GPL" means "GNU Public License
v2 or later",
which is the license text in the file header.
--
Romain Izard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] serial: mctrl_gpio: Add missing module license
2016-02-23 14:54 [PATCH v1] serial: mctrl_gpio: Add missing module license Romain Izard
2016-02-23 15:21 ` Fabio Estevam
@ 2016-02-29 8:49 ` Uwe Kleine-König
1 sibling, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2016-02-29 8:49 UTC (permalink / raw)
To: Romain Izard; +Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, linux-kernel
Hello Romain,
On Tue, Feb 23, 2016 at 03:54:54PM +0100, Romain Izard wrote:
> As the mctrl_gpio driver can be built as a module, it needs to have its
> license specified with MODULE_LICENSE. Otherwise, it cannot access
> required symbols exported through EXPORT_SYMBOL_GPL.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
> drivers/tty/serial/serial_mctrl_gpio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
> index 226ad23b136c..02147361eaa9 100644
> --- a/drivers/tty/serial/serial_mctrl_gpio.c
> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
> @@ -20,6 +20,7 @@
> #include <linux/gpio/consumer.h>
> #include <linux/termios.h>
> #include <linux/serial_core.h>
> +#include <linux/module.h>
>
> #include "serial_mctrl_gpio.h"
>
> @@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios)
> }
> }
> EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
> +
> +MODULE_LICENSE("GPL");
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-29 8:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 14:54 [PATCH v1] serial: mctrl_gpio: Add missing module license Romain Izard
2016-02-23 15:21 ` Fabio Estevam
2016-02-23 16:05 ` Romain Izard
2016-02-29 8:49 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox