* [PATCH] serial: SERIAL_STM32 should depend on HAS_DMA
@ 2016-10-06 13:55 Geert Uytterhoeven
2016-10-06 14:08 ` Alexandre Torgue
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2016-10-06 13:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Maxime Coquelin, Alexandre Torgue
Cc: linux-serial, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
drivers/built-in.o: In function `stm32_serial_remove':
stm32-usart.c:(.text+0xcea1a): undefined reference to `bad_dma_ops'
stm32-usart.c:(.text+0xcea7a): undefined reference to `bad_dma_ops'
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/tty/serial/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index c7831407a882d2bb..25c1d7bc010043b1 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1625,6 +1625,7 @@ config SERIAL_SPRD_CONSOLE
config SERIAL_STM32
tristate "STMicroelectronics STM32 serial port support"
select SERIAL_CORE
+ depends on HAS_DMA
depends on ARM || COMPILE_TEST
help
This driver is for the on-chip Serial Controller on
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: SERIAL_STM32 should depend on HAS_DMA
2016-10-06 13:55 [PATCH] serial: SERIAL_STM32 should depend on HAS_DMA Geert Uytterhoeven
@ 2016-10-06 14:08 ` Alexandre Torgue
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Torgue @ 2016-10-06 14:08 UTC (permalink / raw)
To: Geert Uytterhoeven, Greg Kroah-Hartman, Jiri Slaby,
Maxime Coquelin
Cc: linux-serial, linux-kernel
Hi Geert,
On 10/06/2016 03:55 PM, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `stm32_serial_remove':
> stm32-usart.c:(.text+0xcea1a): undefined reference to `bad_dma_ops'
> stm32-usart.c:(.text+0xcea7a): undefined reference to `bad_dma_ops'
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/tty/serial/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index c7831407a882d2bb..25c1d7bc010043b1 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1625,6 +1625,7 @@ config SERIAL_SPRD_CONSOLE
> config SERIAL_STM32
> tristate "STMicroelectronics STM32 serial port support"
> select SERIAL_CORE
> + depends on HAS_DMA
> depends on ARM || COMPILE_TEST
> help
> This driver is for the on-chip Serial Controller on
>
I sent same kind of patch this morning (but mine have a bad copy paste).
I will abandon my patch.
However for this one:
Acked-by: Alexandre Torgue <alexandre.torgue@st.com>
regards
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-06 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-06 13:55 [PATCH] serial: SERIAL_STM32 should depend on HAS_DMA Geert Uytterhoeven
2016-10-06 14:08 ` Alexandre Torgue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox