* [PATCH] serial: stm32: fix initialization of RS485 mode
@ 2018-03-15 8:44 Bich HEMON
2018-03-15 15:41 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Bich HEMON @ 2018-03-15 8:44 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Maxime Coquelin,
Alexandre TORGUE, Jiri Slaby, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Bich HEMON
Configure RS485 mode during port initialization.
Fixes: 1bcda09d291081a7732fcaa9d1745312404a4e36 ("serial: stm32: add
support for RS485 hardware control mode")
Signed-off-by: Bich Hemon <bich.hemon@st.com>
---
drivers/tty/serial/stm32-usart.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
index 345fbf3..e8d7a7b 100644
--- a/drivers/tty/serial/stm32-usart.c
+++ b/drivers/tty/serial/stm32-usart.c
@@ -809,6 +809,10 @@ static int stm32_init_port(struct stm32_port *stm32port,
port->ops = &stm32_uart_ops;
port->dev = &pdev->dev;
port->irq = platform_get_irq(pdev, 0);
+ port->rs485_config = stm32_config_rs485;
+
+ stm32_init_rs485(port, pdev);
+
stm32port->wakeirq = platform_get_irq(pdev, 1);
stm32port->fifoen = stm32port->info->cfg.has_fifo;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] serial: stm32: fix initialization of RS485 mode
2018-03-15 8:44 [PATCH] serial: stm32: fix initialization of RS485 mode Bich HEMON
@ 2018-03-15 15:41 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2018-03-15 15:41 UTC (permalink / raw)
To: Bich HEMON
Cc: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Maxime Coquelin,
Alexandre TORGUE, Jiri Slaby, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Thu, Mar 15, 2018 at 9:44 AM, Bich HEMON <bich.hemon@st.com> wrote:
> Configure RS485 mode during port initialization.
>
> Fixes: 1bcda09d291081a7732fcaa9d1745312404a4e36 ("serial: stm32: add
> support for RS485 hardware control mode")
>
> Signed-off-by: Bich Hemon <bich.hemon@st.com>
I noticed the unused-function warning from the original patch, and the
patch also fixes that (besides looking like it does the right thing).
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-15 15:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-15 8:44 [PATCH] serial: stm32: fix initialization of RS485 mode Bich HEMON
2018-03-15 15:41 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox