* [PATCH] ipwireless: check ppp register worked
@ 2012-09-17 11:01 Alan Cox
0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2012-09-17 11:01 UTC (permalink / raw)
To: greg, linux-serial
From: Alan Cox <alan@linux.intel.com>
Otherwise we start trying to use a bogus channel - ungood.
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/tty/ipwireless/network.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/ipwireless/network.c b/drivers/tty/ipwireless/network.c
index 90ea902..57102e6 100644
--- a/drivers/tty/ipwireless/network.c
+++ b/drivers/tty/ipwireless/network.c
@@ -274,7 +274,12 @@ static void do_go_online(struct work_struct *work_go_online)
network->xaccm[0] = ~0U;
network->xaccm[3] = 0x60000000U;
network->raccm = ~0U;
- ppp_register_channel(channel);
+ if (ppp_register_channel(channel) < 0) {
+ printk(KERN_ERR IPWIRELESS_PCCARD_NAME
+ ": unable to register PPP channel\n");
+ kfree(channel);
+ return;
+ }
spin_lock_irqsave(&network->lock, flags);
network->ppp_channel = channel;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-09-17 10:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-17 11:01 [PATCH] ipwireless: check ppp register worked Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox