* [PATCH 1/2] pbn_b0_8_1152000_200 is supposed to be an 8 port definition
@ 2012-12-05 20:56 Matt Schulte
2012-12-05 20:56 ` [PATCH 2/2] The correct device id for this card is 0x0022 Matt Schulte
0 siblings, 1 reply; 6+ messages in thread
From: Matt Schulte @ 2012-12-05 20:56 UTC (permalink / raw)
To: linux-serial; +Cc: alan, greg, Matt Schulte
Signed-off-by: Matt Schulte <matts@commtech-fastcom.com>
---
Built against tty-next commit: b0ab02361167faa82198b783a8d555eb6f58901c
drivers/tty/serial/8250/8250_pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 26b9dc0..bf2f1a0 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -2246,7 +2246,7 @@ static struct pciserial_board pci_boards[] = {
[pbn_b0_8_1152000_200] = {
.flags = FL_BASE0,
- .num_ports = 2,
+ .num_ports = 8,
.base_baud = 1152000,
.uart_offset = 0x200,
},
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] The correct device id for this card is 0x0022.
2012-12-05 20:56 [PATCH 1/2] pbn_b0_8_1152000_200 is supposed to be an 8 port definition Matt Schulte
@ 2012-12-05 20:56 ` Matt Schulte
2012-12-05 21:38 ` Alan Cox
0 siblings, 1 reply; 6+ messages in thread
From: Matt Schulte @ 2012-12-05 20:56 UTC (permalink / raw)
To: linux-serial; +Cc: alan, greg, Matt Schulte
Signed-off-by: Matt Schulte <matts@commtech-fastcom.com>
---
Built against tty-next commit: b0ab02361167faa82198b783a8d555eb6f58901c
drivers/tty/serial/8250/8250_pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index bf2f1a0..777832c 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -1301,7 +1301,7 @@ pci_wch_ch353_setup(struct serial_private *priv,
#define PCI_VENDOR_ID_AGESTAR 0x5372
#define PCI_DEVICE_ID_AGESTAR_9375 0x6872
#define PCI_VENDOR_ID_ASIX 0x9710
-#define PCI_DEVICE_ID_COMMTECH_4222PCIE 0x0019
+#define PCI_DEVICE_ID_COMMTECH_4222PCIE 0x0022
#define PCI_DEVICE_ID_COMMTECH_4224PCIE 0x0020
#define PCI_DEVICE_ID_COMMTECH_4228PCIE 0x0021
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] The correct device id for this card is 0x0022.
2012-12-05 20:56 ` [PATCH 2/2] The correct device id for this card is 0x0022 Matt Schulte
@ 2012-12-05 21:38 ` Alan Cox
2012-12-05 22:20 ` Will Fagan
0 siblings, 1 reply; 6+ messages in thread
From: Alan Cox @ 2012-12-05 21:38 UTC (permalink / raw)
To: Matt Schulte; +Cc: linux-serial, greg, Matt Schulte
On Wed, 5 Dec 2012 14:56:22 -0600
Matt Schulte <matts_old@commtech-fastcom.com> wrote:
> Signed-off-by: Matt Schulte <matts@commtech-fastcom.com>
> ---
> Built against tty-next commit: b0ab02361167faa82198b783a8d555eb6f58901c
>
> drivers/tty/serial/8250/8250_pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index bf2f1a0..777832c 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -1301,7 +1301,7 @@ pci_wch_ch353_setup(struct serial_private *priv,
> #define PCI_VENDOR_ID_AGESTAR 0x5372
> #define PCI_DEVICE_ID_AGESTAR_9375 0x6872
> #define PCI_VENDOR_ID_ASIX 0x9710
> -#define PCI_DEVICE_ID_COMMTECH_4222PCIE 0x0019
> +#define PCI_DEVICE_ID_COMMTECH_4222PCIE 0x0022
> #define PCI_DEVICE_ID_COMMTECH_4224PCIE 0x0020
> #define PCI_DEVICE_ID_COMMTECH_4228PCIE 0x0021
Can you keep them in order 8)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] The correct device id for this card is 0x0022.
2012-12-05 21:38 ` Alan Cox
@ 2012-12-05 22:20 ` Will Fagan
2013-01-16 2:59 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Will Fagan @ 2012-12-05 22:20 UTC (permalink / raw)
To: Alan Cox; +Cc: Matt Schulte, linux-serial, greg, Matt Schulte
I just spoke with Matt. He isn't by his email and asked if he only
needed to resend the patch with the reordering or both patches?
Will
Commtech, Inc.
Voice: 316-636-1131
Fax: 316-636-1163
http://www.commtech-fastcom.com
On Wed, Dec 5, 2012 at 3:38 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> On Wed, 5 Dec 2012 14:56:22 -0600
> Matt Schulte <matts_old@commtech-fastcom.com> wrote:
>
> > Signed-off-by: Matt Schulte <matts@commtech-fastcom.com>
> > ---
> > Built against tty-next commit: b0ab02361167faa82198b783a8d555eb6f58901c
> >
> > drivers/tty/serial/8250/8250_pci.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> > index bf2f1a0..777832c 100644
> > --- a/drivers/tty/serial/8250/8250_pci.c
> > +++ b/drivers/tty/serial/8250/8250_pci.c
> > @@ -1301,7 +1301,7 @@ pci_wch_ch353_setup(struct serial_private *priv,
> > #define PCI_VENDOR_ID_AGESTAR 0x5372
> > #define PCI_DEVICE_ID_AGESTAR_9375 0x6872
> > #define PCI_VENDOR_ID_ASIX 0x9710
> > -#define PCI_DEVICE_ID_COMMTECH_4222PCIE 0x0019
> > +#define PCI_DEVICE_ID_COMMTECH_4222PCIE 0x0022
> > #define PCI_DEVICE_ID_COMMTECH_4224PCIE 0x0020
> > #define PCI_DEVICE_ID_COMMTECH_4228PCIE 0x0021
>
> Can you keep them in order 8)
>
On Wed, Dec 5, 2012 at 3:38 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Wed, 5 Dec 2012 14:56:22 -0600
> Matt Schulte <matts_old@commtech-fastcom.com> wrote:
>
>> Signed-off-by: Matt Schulte <matts@commtech-fastcom.com>
>> ---
>> Built against tty-next commit: b0ab02361167faa82198b783a8d555eb6f58901c
>>
>> drivers/tty/serial/8250/8250_pci.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
>> index bf2f1a0..777832c 100644
>> --- a/drivers/tty/serial/8250/8250_pci.c
>> +++ b/drivers/tty/serial/8250/8250_pci.c
>> @@ -1301,7 +1301,7 @@ pci_wch_ch353_setup(struct serial_private *priv,
>> #define PCI_VENDOR_ID_AGESTAR 0x5372
>> #define PCI_DEVICE_ID_AGESTAR_9375 0x6872
>> #define PCI_VENDOR_ID_ASIX 0x9710
>> -#define PCI_DEVICE_ID_COMMTECH_4222PCIE 0x0019
>> +#define PCI_DEVICE_ID_COMMTECH_4222PCIE 0x0022
>> #define PCI_DEVICE_ID_COMMTECH_4224PCIE 0x0020
>> #define PCI_DEVICE_ID_COMMTECH_4228PCIE 0x0021
>
> Can you keep them in order 8)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
William Fagan
Commtech, Inc.
Voice: 316-636-1131
Fax: 316-636-1163
http://www.commtech-fastcom.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] The correct device id for this card is 0x0022.
2012-12-05 22:20 ` Will Fagan
@ 2013-01-16 2:59 ` Greg KH
2013-01-16 3:00 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2013-01-16 2:59 UTC (permalink / raw)
To: Will Fagan; +Cc: Alan Cox, Matt Schulte, linux-serial, Matt Schulte
On Wed, Dec 05, 2012 at 04:20:56PM -0600, Will Fagan wrote:
> I just spoke with Matt. He isn't by his email and asked if he only
> needed to resend the patch with the reordering or both patches?
Both patches please.
Also, please let me know "what" card you are talking about here in the
subject and body of the patch. Also the device type as well?
ideally the Subject would look like:
Subject: tty: serial: fix device id for the FOO device
Can you resend both of these after fixing that up so that I can apply
them?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] The correct device id for this card is 0x0022.
2013-01-16 2:59 ` Greg KH
@ 2013-01-16 3:00 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2013-01-16 3:00 UTC (permalink / raw)
To: Will Fagan; +Cc: Alan Cox, Matt Schulte, linux-serial, Matt Schulte
On Tue, Jan 15, 2013 at 06:59:38PM -0800, Greg KH wrote:
> On Wed, Dec 05, 2012 at 04:20:56PM -0600, Will Fagan wrote:
> > I just spoke with Matt. He isn't by his email and asked if he only
> > needed to resend the patch with the reordering or both patches?
>
> Both patches please.
>
> Also, please let me know "what" card you are talking about here in the
> subject and body of the patch. Also the device type as well?
>
> ideally the Subject would look like:
> Subject: tty: serial: fix device id for the FOO device
>
> Can you resend both of these after fixing that up so that I can apply
> them?
Oh nevermind, it looks like it was resent, my todo patch queue is looney
right now, sorry for the noise.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-16 2:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-05 20:56 [PATCH 1/2] pbn_b0_8_1152000_200 is supposed to be an 8 port definition Matt Schulte
2012-12-05 20:56 ` [PATCH 2/2] The correct device id for this card is 0x0022 Matt Schulte
2012-12-05 21:38 ` Alan Cox
2012-12-05 22:20 ` Will Fagan
2013-01-16 2:59 ` Greg KH
2013-01-16 3:00 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox