[PATCH 08/10] serial: pxa: Staticize local symbols

[PATCH 08/10] serial: pxa: Staticize local symbols

[Jingoo Han]

>From 954e4e864408be296bad2488fb133c2ea163f90f Mon Sep 17 00:00:00 2001
From: Jingoo Han <jg1.han@samsung.com>
Date: Thu, 8 Aug 2013 17:15:08 +0900
Subject: [PATCH 08/10] serial: pxa: Staticize local symbols

These local symbols are used only in this file.
Fix the following sparse warnings:

drivers/tty/serial/pxa.c:793:17: warning: symbol 'serial_pxa_pops' was not declared. Should it be static?
drivers/tty/serial/pxa.c:971:12: warning: symbol 'serial_pxa_init' was not declared. Should it be static?
drivers/tty/serial/pxa.c:986:13: warning: symbol 'serial_pxa_exit' was not declared. Should it be static?

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/tty/serial/pxa.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/pxa.c b/drivers/tty/serial/pxa.c
index ac8b2f5..290f514 100644
--- a/drivers/tty/serial/pxa.c
+++ b/drivers/tty/serial/pxa.c
@@ -790,7 +790,7 @@ static struct console serial_pxa_console = {
 #define PXA_CONSOLE	NULL
 #endif
 
-struct uart_ops serial_pxa_pops = {
+static struct uart_ops serial_pxa_pops = {
 	.tx_empty	= serial_pxa_tx_empty,
 	.set_mctrl	= serial_pxa_set_mctrl,
 	.get_mctrl	= serial_pxa_get_mctrl,
@@ -968,7 +968,7 @@ static struct platform_driver serial_pxa_driver = {
 	},
 };
 
-int __init serial_pxa_init(void)
+static int __init serial_pxa_init(void)
 {
 	int ret;
 
@@ -983,7 +983,7 @@ int __init serial_pxa_init(void)
 	return ret;
 }
 
-void __exit serial_pxa_exit(void)
+static void __exit serial_pxa_exit(void)
 {
 	platform_driver_unregister(&serial_pxa_driver);
 	uart_unregister_driver(&serial_pxa_reg);
-- 
1.7.10.4

Re: [PATCH 08/10] serial: pxa: Staticize local symbols

['Greg Kroah-Hartman']

On Thu, Aug 08, 2013 at 05:39:51PM +0900, Jingoo Han wrote:
> >From 954e4e864408be296bad2488fb133c2ea163f90f Mon Sep 17 00:00:00 2001
> From: Jingoo Han <jg1.han@samsung.com>
> Date: Thu, 8 Aug 2013 17:15:08 +0900
> Subject: [PATCH 08/10] serial: pxa: Staticize local symbols

Why include this in the message body again?  Please use 'git send-email'
to prevent stuff like this from happening, forcing me to edit the patch
by hand :(

greg k-h