From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: James Hogan <james@albanarts.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Gregory Clement <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Jason Cooper <jason@lakedaemon.net>,
James Hogan <james.hogan@imgtec.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>, Tim Kryger <tim.kryger@linaro.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Matt Porter <matt.porter@linaro.org>,
Markus Mayer <markus.mayer@linaro.org>
Subject: Re: [PATCH] serial: 8250_dw: Fix LCR workaround regression
Date: Wed, 11 Dec 2013 16:00:15 +0200 [thread overview]
Message-ID: <20131211140014.GF28456@xps8300> (raw)
In-Reply-To: <1386714484-30251-1-git-send-email-james@albanarts.com>
Hi,
On Tue, Dec 10, 2013 at 10:28:04PM +0000, James Hogan wrote:
> From: James Hogan <james.hogan@imgtec.com>
>
> Commit c49436b657d0 (serial: 8250_dw: Improve unwritable LCR workaround)
> caused a regression. It added a check that the LCR was written properly
> to detect and workaround the busy quirk, but the behaviour of bit 5
> (UART_LCR_SPAR) differs between IP versions 3.00a and 3.14c per the
> docs. On older versions this caused the check to fail and it would
> repeatedly force idle and rewrite the LCR register, causing delays and
> preventing any input from serial being received.
>
> This is fixed by masking out UART_LCR_SPAR before making the comparison.
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.cz>
> Cc: Tim Kryger <tim.kryger@linaro.org>
> Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Cc: Matt Porter <matt.porter@linaro.org>
> Cc: Markus Mayer <markus.mayer@linaro.org>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Tested-by: Tim Kryger <tim.kryger@linaro.org>
> Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
I tested this with HW without the busy functionality
(UART_16550_COMPATIBLE == yes). No problems here. FWIW:
Tested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
--
heikki
next prev parent reply other threads:[~2013-12-11 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 22:28 [PATCH] serial: 8250_dw: Fix LCR workaround regression James Hogan
2013-12-11 14:00 ` Heikki Krogerus [this message]
2013-12-11 21:00 ` Tim Kryger
2013-12-11 21:05 ` James Hogan
2013-12-12 1:00 ` Tim Kryger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211140014.GF28456@xps8300 \
--to=heikki.krogerus@linux.intel.com \
--cc=alior@marvell.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@free-electrons.com \
--cc=james.hogan@imgtec.com \
--cc=james@albanarts.com \
--cc=jason@lakedaemon.net \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=matt.porter@linaro.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tim.kryger@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox