From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 0/3] s/FOOTBRIDGE/ARCH_FOOTBRIDGE/
Date: Tue, 1 Jul 2014 23:14:28 +0100 [thread overview]
Message-ID: <20140701221428.GC32514@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1404247026-379-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Tue, Jul 01, 2014 at 10:37:03PM +0200, Uwe Kleine-König wrote:
> Hello Russell,
>
> I'm not sure that FOOTBRIDGE and ARCH_FOOTBRIDGE are semantically
> identical; if not, feel free to nack this series.
CONFIG_FOOTBRIDGE means that we have a DC21285 in the system. We
used to have ARCH_FOOTBRIDGE and ARCH_CO285 which both selected
CONFIG_FOOTBRIDGE.
ARCH_FOOTBRIDGE was for either host or addin mode using a PAGE_OFFSET
of 0xc0000000. ARCH_CO285 had a PAGE_OFFSET of 0x80000000 as they
wanted to be able to map almost all of PCI memory space.
So think of CONFIG_FOOTBRIDGE as meaning that we have the physical
device, and CONFIG_ARCH_FOOTBRIDGE meaning that we want to support
boards with the device on.
So, it may make sense to rename CONFIG_FOOTBRIDGE to CONFIG_DC21285
if that makes the configuration symbol intention clearer.
This is why I prefer even hidden symbols to have a help text - having
the help text explains why they exist...
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-01 22:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 20:37 [PATCH 0/3] s/FOOTBRIDGE/ARCH_FOOTBRIDGE/ Uwe Kleine-König
2014-07-01 20:37 ` [PATCH 1/3] serial: DC21285: depend on ARCH_FOOTBRIDGE instead of FOOTBRIDGE Uwe Kleine-König
2014-07-01 22:14 ` Russell King - ARM Linux [this message]
2014-07-02 7:13 ` [PATCH 0/3] s/FOOTBRIDGE/ARCH_FOOTBRIDGE/ Uwe Kleine-König
2014-07-02 16:26 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701221428.GC32514@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).