* [PATCH] serial: Fix build failure caused by missing header file [not found] <1408553745-3536-1-git-send-email-bobby.prani@gmail.com> @ 2014-08-20 16:55 ` Pranith Kumar 2014-08-25 20:13 ` Greg Kroah-Hartman 0 siblings, 1 reply; 4+ messages in thread From: Pranith Kumar @ 2014-08-20 16:55 UTC (permalink / raw) To: Greg Kroah-Hartman, Jiri Slaby, open list:SERIAL DRIVERS, open list Fix build failure caused by missing header file: drivers/tty/serial/nwpserial.c: In function 'wait_for_bits': drivers/tty/serial/nwpserial.c:53:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration] Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> --- drivers/tty/serial/nwpserial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/nwpserial.c b/drivers/tty/serial/nwpserial.c index c06366b..5da7622 100644 --- a/drivers/tty/serial/nwpserial.c +++ b/drivers/tty/serial/nwpserial.c @@ -22,6 +22,7 @@ #include <linux/of_platform.h> #include <linux/of_device.h> #include <linux/nwpserial.h> +#include <linux/delay.h> #include <asm/prom.h> #include <asm/dcr.h> -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: Fix build failure caused by missing header file 2014-08-20 16:55 ` [PATCH] serial: Fix build failure caused by missing header file Pranith Kumar @ 2014-08-25 20:13 ` Greg Kroah-Hartman 2014-08-25 23:00 ` Pranith Kumar 0 siblings, 1 reply; 4+ messages in thread From: Greg Kroah-Hartman @ 2014-08-25 20:13 UTC (permalink / raw) To: Pranith Kumar; +Cc: Jiri Slaby, open list:SERIAL DRIVERS, open list On Wed, Aug 20, 2014 at 12:55:45PM -0400, Pranith Kumar wrote: > Fix build failure caused by missing header file: > > drivers/tty/serial/nwpserial.c: In function 'wait_for_bits': > drivers/tty/serial/nwpserial.c:53:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration] > > Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> > --- > drivers/tty/serial/nwpserial.c | 1 + > 1 file changed, 1 insertion(+) Where is this failing? What arch? What kernel version did it show up in (i.e. what commit caused this problem?) thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: Fix build failure caused by missing header file 2014-08-25 20:13 ` Greg Kroah-Hartman @ 2014-08-25 23:00 ` Pranith Kumar 2014-08-25 23:22 ` Greg Kroah-Hartman 0 siblings, 1 reply; 4+ messages in thread From: Pranith Kumar @ 2014-08-25 23:00 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Jiri Slaby, open list:SERIAL DRIVERS, open list On Mon, Aug 25, 2014 at 4:13 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > Where is this failing? What arch? What kernel version did it show up > in (i.e. what commit caused this problem?) > This was a randconfig on powerpc. I did not bisect as to which commit introduced this since it is a simple missing header file. -- Pranith ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: Fix build failure caused by missing header file 2014-08-25 23:00 ` Pranith Kumar @ 2014-08-25 23:22 ` Greg Kroah-Hartman 0 siblings, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2014-08-25 23:22 UTC (permalink / raw) To: Pranith Kumar; +Cc: Jiri Slaby, open list:SERIAL DRIVERS, open list On Mon, Aug 25, 2014 at 07:00:36PM -0400, Pranith Kumar wrote: > On Mon, Aug 25, 2014 at 4:13 PM, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > Where is this failing? What arch? What kernel version did it show up > > in (i.e. what commit caused this problem?) > > > > This was a randconfig on powerpc. I did not bisect as to which commit > introduced this since it is a simple missing header file. Ok, so I guess it's not worth getting into 3.17, I'll queue it up for 3.18 in a few days. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-25 23:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1408553745-3536-1-git-send-email-bobby.prani@gmail.com>
2014-08-20 16:55 ` [PATCH] serial: Fix build failure caused by missing header file Pranith Kumar
2014-08-25 20:13 ` Greg Kroah-Hartman
2014-08-25 23:00 ` Pranith Kumar
2014-08-25 23:22 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox