* [PATCH v2] serial: sh-sci: Fix init data attribute for struct 'port_cfg'
@ 2017-10-10 1:26 Matthias Kaehlcke
2017-10-10 1:54 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Kaehlcke @ 2017-10-10 1:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: linux-serial, linux-kernel, Arnd Bergmann, Guenter Roeck,
Matthias Kaehlcke
The __init attribute is meant to mark functions, use __initdata instead
for the data structure.
This fixes the following error when building with clang:
drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only
applies to functions, methods, properties, and global variables
static struct __init plat_sci_port port_cfg;
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v2:
- Change the attribute to __initdata instead of removing it
- Update commit message
drivers/tty/serial/sh-sci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index 784dd42002ea..f7f632213a8e 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -3244,7 +3244,7 @@ early_platform_init_buffer("earlyprintk", &sci_driver,
early_serial_buf, ARRAY_SIZE(early_serial_buf));
#endif
#ifdef CONFIG_SERIAL_SH_SCI_EARLYCON
-static struct __init plat_sci_port port_cfg;
+static struct plat_sci_port port_cfg __initdata;
static int __init early_console_setup(struct earlycon_device *device,
int type)
--
2.14.2.920.gcf0c67979c-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] serial: sh-sci: Fix init data attribute for struct 'port_cfg'
2017-10-10 1:26 [PATCH v2] serial: sh-sci: Fix init data attribute for struct 'port_cfg' Matthias Kaehlcke
@ 2017-10-10 1:54 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2017-10-10 1:54 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, linux-kernel,
Arnd Bergmann, Guenter Roeck
On Mon, Oct 9, 2017 at 6:26 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> The __init attribute is meant to mark functions, use __initdata instead
> for the data structure.
>
> This fixes the following error when building with clang:
>
> drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only
> applies to functions, methods, properties, and global variables
> static struct __init plat_sci_port port_cfg;
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> Changes in v2:
> - Change the attribute to __initdata instead of removing it
> - Update commit message
>
> drivers/tty/serial/sh-sci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 784dd42002ea..f7f632213a8e 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -3244,7 +3244,7 @@ early_platform_init_buffer("earlyprintk", &sci_driver,
> early_serial_buf, ARRAY_SIZE(early_serial_buf));
> #endif
> #ifdef CONFIG_SERIAL_SH_SCI_EARLYCON
> -static struct __init plat_sci_port port_cfg;
> +static struct plat_sci_port port_cfg __initdata;
>
> static int __init early_console_setup(struct earlycon_device *device,
> int type)
> --
> 2.14.2.920.gcf0c67979c-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-10 1:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-10 1:26 [PATCH v2] serial: sh-sci: Fix init data attribute for struct 'port_cfg' Matthias Kaehlcke
2017-10-10 1:54 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox