[PATCH v1 1/1] serial: 8250_dw: Sort headers alphabetically

[PATCH v1 1/1] serial: 8250_dw: Sort headers alphabetically

[Andy Shevchenko]

For the sake of better maintenance, sort included headers alphabetically.
While at it, split the serial group of headers which makes clear the
subsystem the driver belongs to.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/tty/serial/8250/8250_dw.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index d5df17455f1d..86762593579f 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -9,26 +9,27 @@
  * LCR is written whilst busy.  If it is, then a busy detect interrupt is
  * raised, the LCR needs to be rewritten and the uart status register read.
  */
+#include <linux/acpi.h>
+#include <linux/clk.h>
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/io.h>
 #include <linux/mod_devicetable.h>
 #include <linux/module.h>
-#include <linux/serial_8250.h>
-#include <linux/serial_reg.h>
+#include <linux/notifier.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
 #include <linux/property.h>
-#include <linux/workqueue.h>
-#include <linux/notifier.h>
-#include <linux/slab.h>
-#include <linux/acpi.h>
-#include <linux/clk.h>
 #include <linux/reset.h>
-#include <linux/pm_runtime.h>
+#include <linux/slab.h>
+#include <linux/workqueue.h>
 
 #include <asm/byteorder.h>
 
+#include <linux/serial_8250.h>
+#include <linux/serial_reg.h>
+
 #include "8250_dwlib.h"
 
 /* Offsets for the DesignWare specific registers */
-- 
2.35.1

Re: [PATCH v1 1/1] serial: 8250_dw: Sort headers alphabetically

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

On Thu, 30 Jun 2022, Andy Shevchenko wrote:

> For the sake of better maintenance, sort included headers alphabetically.
> While at it, split the serial group of headers which makes clear the
> subsystem the driver belongs to.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.

Re: [PATCH v1 1/1] serial: 8250_dw: Sort headers alphabetically

[Greg Kroah-Hartman]

On Thu, Jun 30, 2022 at 12:38:16PM +0300, Andy Shevchenko wrote:
> For the sake of better maintenance, sort included headers alphabetically.

How does that make anything easier to maintain?

> While at it, split the serial group of headers which makes clear the
> subsystem the driver belongs to.

Where did you do that?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/tty/serial/8250/8250_dw.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
> index d5df17455f1d..86762593579f 100644
> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -9,26 +9,27 @@
>   * LCR is written whilst busy.  If it is, then a busy detect interrupt is
>   * raised, the LCR needs to be rewritten and the uart status register read.
>   */
> +#include <linux/acpi.h>
> +#include <linux/clk.h>
>  #include <linux/delay.h>
>  #include <linux/device.h>
>  #include <linux/io.h>
>  #include <linux/mod_devicetable.h>
>  #include <linux/module.h>
> -#include <linux/serial_8250.h>
> -#include <linux/serial_reg.h>
> +#include <linux/notifier.h>
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
> +#include <linux/pm_runtime.h>
>  #include <linux/property.h>
> -#include <linux/workqueue.h>
> -#include <linux/notifier.h>
> -#include <linux/slab.h>
> -#include <linux/acpi.h>
> -#include <linux/clk.h>
>  #include <linux/reset.h>
> -#include <linux/pm_runtime.h>
> +#include <linux/slab.h>
> +#include <linux/workqueue.h>
>  
>  #include <asm/byteorder.h>
>  
> +#include <linux/serial_8250.h>
> +#include <linux/serial_reg.h>

Is this the "split"?

Anyway, it's just code churn, I'll apply it...

thanks,

greg k-h