From: Hugo Villeneuve <hugo@hugovil.com>
To: m.brock@vanmierlo.com
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jirislaby@kernel.org, jringle@gridpoint.com,
l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
stable@vger.kernel.org,
Lech Perczak <lech.perczak@camlingroup.com>
Subject: Re: [PATCH v5 3/9] serial: sc16is7xx: refactor GPIO controller registration
Date: Thu, 1 Jun 2023 14:27:24 -0400 [thread overview]
Message-ID: <20230601142724.4fb197fd315e6d360c0d0457@hugovil.com> (raw)
In-Reply-To: <c5c2879e55102a6d517245e6d251290d@vanmierlo.com>
On Thu, 01 Jun 2023 19:28:01 +0200
m.brock@vanmierlo.com wrote:
> Hugo Villeneuve schreef op 2023-06-01 18:31:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> >
> > In preparation for upcoming patch "fix regression with GPIO
> > configuration". To facilitate review and make code more modular.
> >
> > Cc: <stable@vger.kernel.org> # 6.1.x
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com>
> > Tested-by: Lech Perczak <lech.perczak@camlingroup.com>
> > ---
> > drivers/tty/serial/sc16is7xx.c | 39 ++++++++++++++++++++--------------
> > 1 file changed, 23 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/tty/serial/sc16is7xx.c
> > b/drivers/tty/serial/sc16is7xx.c
> > index 0c903d44429c..279d7dcb1447 100644
> > --- a/drivers/tty/serial/sc16is7xx.c
> > +++ b/drivers/tty/serial/sc16is7xx.c
> > @@ -1349,6 +1349,26 @@ static int
> > sc16is7xx_gpio_direction_output(struct gpio_chip *chip,
> >
> > return 0;
> > }
> > +
> > +static int sc16is7xx_setup_gpio_chip(struct device *dev)
>
> Only one parameter, but...
>
> > + ret = sc16is7xx_setup_gpio_chip(dev, mctrl_mask);
>
> called with two.
Hi Maarten,
sorry about that, I will fix this for V6.
Somehow my automated compile script tested each patch separately, including this one, but the defconfig didn't enable the module sc6is7xx, so the error went unnoticed. I wrongly assumed that "make alldefconfig" enabled all modules, I will instead use "make allyesconfig".
Hugo.
next prev parent reply other threads:[~2023-06-01 18:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 16:31 [PATCH v5 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 1/9] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 2/9] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 3/9] serial: sc16is7xx: refactor GPIO controller registration Hugo Villeneuve
2023-06-01 17:28 ` m.brock
2023-06-01 18:27 ` Hugo Villeneuve [this message]
2023-06-01 16:31 ` [PATCH v5 4/9] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 5/9] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 6/9] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 7/9] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 8/9] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 9/9] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601142724.4fb197fd315e6d360c0d0457@hugovil.com \
--to=hugo@hugovil.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.perczak@camlintechnologies.com \
--cc=lech.perczak@camlingroup.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.brock@vanmierlo.com \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox