From: m.brock@vanmierlo.com
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jirislaby@kernel.org, jringle@gridpoint.com,
l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
stable@vger.kernel.org,
Lech Perczak <lech.perczak@camlingroup.com>
Subject: Re: [PATCH v5 3/9] serial: sc16is7xx: refactor GPIO controller registration
Date: Thu, 01 Jun 2023 19:28:01 +0200 [thread overview]
Message-ID: <c5c2879e55102a6d517245e6d251290d@vanmierlo.com> (raw)
In-Reply-To: <20230601163113.2785657-4-hugo@hugovil.com>
Hugo Villeneuve schreef op 2023-06-01 18:31:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> In preparation for upcoming patch "fix regression with GPIO
> configuration". To facilitate review and make code more modular.
>
> Cc: <stable@vger.kernel.org> # 6.1.x
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com>
> Tested-by: Lech Perczak <lech.perczak@camlingroup.com>
> ---
> drivers/tty/serial/sc16is7xx.c | 39 ++++++++++++++++++++--------------
> 1 file changed, 23 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c
> b/drivers/tty/serial/sc16is7xx.c
> index 0c903d44429c..279d7dcb1447 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -1349,6 +1349,26 @@ static int
> sc16is7xx_gpio_direction_output(struct gpio_chip *chip,
>
> return 0;
> }
> +
> +static int sc16is7xx_setup_gpio_chip(struct device *dev)
Only one parameter, but...
> + ret = sc16is7xx_setup_gpio_chip(dev, mctrl_mask);
called with two.
Maarten
next prev parent reply other threads:[~2023-06-01 17:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 16:31 [PATCH v5 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 1/9] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 2/9] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 3/9] serial: sc16is7xx: refactor GPIO controller registration Hugo Villeneuve
2023-06-01 17:28 ` m.brock [this message]
2023-06-01 18:27 ` Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 4/9] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 5/9] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 6/9] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 7/9] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 8/9] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-06-01 16:31 ` [PATCH v5 9/9] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5c2879e55102a6d517245e6d251290d@vanmierlo.com \
--to=m.brock@vanmierlo.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.perczak@camlintechnologies.com \
--cc=lech.perczak@camlingroup.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox