From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Howell <matthew.howell@sealevel.com>
Cc: linux-serial@vger.kernel.org, jeff.baldwin@sealevel.com,
james.olson@sealevel.com, ryan.wenglarz@sealevel.com,
darren.beeson@sealevel.com
Subject: Re: [PATCH 1/2] serial: exar: Remove Sealevel 7xxxC IDs
Date: Mon, 21 Aug 2023 21:36:54 +0200 [thread overview]
Message-ID: <2023082111-accustom-snaking-6055@gregkh> (raw)
In-Reply-To: <82dd7d4-2020-639-c63b-5955ccc08b63@sealevel.com>
On Mon, Aug 21, 2023 at 03:09:22PM -0400, Matthew Howell wrote:
> On Mon, 21 Aug 2023, Greg KH wrote:
>
> > ⚠Caution: External email. Exercise extreme caution with links or attachments.⚠
> >
> >
> > On Mon, Aug 21, 2023 at 12:06:17PM -0400, Matthew Howell wrote:
> > > From: Matthew Howell <matthew.howell@sealevel.com>
> > >
> > > These Sealevel 7xxxC IDs are no longer needed because we (Sealevel) will
> > > be releasing the cards with the standard Exar hardware IDs. This is due
> > > to the selected IDs causing unexpected behaviors on some Windows systems.
> > >
> > > Reverts: 14ee78d ("Add support for Sealevel 7xxxC serial cards")
> >
> > If this is a real "revert", then perhaps just do that revert instead?
>
> I will try that if that is preferable.
It is please.
> > Also, as per our documentation, you need a sha1 a bit longer than that
> > :)
>
> Sorry, I thought I had seen them referenced as 7 characters in other
> posts. Will fix when I resubmit.
>
> >
> > And "Reverts:" isn't a valid tag, perhaps "Fixes:"?
> >
> > And meta-note, your patch series was not linked together, how did you
> > send them?
>
> I used Alpine.
> Sorry for the hassle...but could you clarify how they should be linked? Do
> you mean I should have sent the second patch as a reply to this one?
Yes. That way our tools automatically pick it up as a patch series.
> I didn't see any specifics about patch linking in the documentation so I
> am not/was not clear on the intended or 'best practice' way of linking
> patches.
git send-email does it automatically for you, or you have to do it
manually if you don't use that, sorry.
thanks,
greg k-h
prev parent reply other threads:[~2023-08-21 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 16:06 [PATCH 1/2] serial: exar: Remove Sealevel 7xxxC IDs Matthew Howell
2023-08-21 16:25 ` Greg KH
2023-08-21 19:09 ` Matthew Howell
2023-08-21 19:36 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023082111-accustom-snaking-6055@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=darren.beeson@sealevel.com \
--cc=james.olson@sealevel.com \
--cc=jeff.baldwin@sealevel.com \
--cc=linux-serial@vger.kernel.org \
--cc=matthew.howell@sealevel.com \
--cc=ryan.wenglarz@sealevel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox