[PATCH 1/2] serial: exar: Remove Sealevel 7xxxC IDs

[PATCH 1/2] serial: exar: Remove Sealevel 7xxxC IDs

[Matthew Howell]

From: Matthew Howell <matthew.howell@sealevel.com>

These Sealevel 7xxxC IDs are no longer needed because we (Sealevel) will
be releasing the cards with the standard Exar hardware IDs. This is due
to the selected IDs causing unexpected behaviors on some Windows systems.

Reverts: 14ee78d ("Add support for Sealevel 7xxxC serial cards")
Signed-off-by: Matthew Howell <matthew.howell@sealevel.com>
---
diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index 077c3ba3539e..018cbaaf238c 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -47,12 +47,6 @@
 #define PCI_SUBDEVICE_ID_USR_2980		0x0128
 #define PCI_SUBDEVICE_ID_USR_2981		0x0129
 
-#define PCI_DEVICE_ID_SEALEVEL_710xC		0x1001
-#define PCI_DEVICE_ID_SEALEVEL_720xC		0x1002
-#define PCI_DEVICE_ID_SEALEVEL_740xC		0x1004
-#define PCI_DEVICE_ID_SEALEVEL_780xC		0x1008
-#define PCI_DEVICE_ID_SEALEVEL_716xC		0x1010
-
 #define UART_EXAR_INT0		0x80
 #define UART_EXAR_8XMODE	0x88	/* 8X sampling rate select */
 #define UART_EXAR_SLEEP		0x8b	/* Sleep mode */
@@ -652,8 +646,6 @@ exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent)
 		nr_ports = BIT(((pcidev->device & 0x38) >> 3) - 1);
 	else if (board->num_ports)
 		nr_ports = board->num_ports;
-	else if (pcidev->vendor == PCI_VENDOR_ID_SEALEVEL)
-		nr_ports = pcidev->device & 0xff;
 	else
 		nr_ports = pcidev->device & 0x0f;
 
@@ -894,11 +886,6 @@ static const struct pci_device_id exar_pci_tbl[] = {
 	EXAR_DEVICE(COMMTECH, 2324PCI335, pbn_fastcom335_4),
 	EXAR_DEVICE(COMMTECH, 2328PCI335, pbn_fastcom335_8),
 
-	EXAR_DEVICE(SEALEVEL, 710xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 720xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 740xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 780xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 716xC, pbn_exar_XR17V35x),
 	{ 0, }
 };
 MODULE_DEVICE_TABLE(pci, exar_pci_tbl);

Re: [PATCH 1/2] serial: exar: Remove Sealevel 7xxxC IDs

[Greg KH]

On Mon, Aug 21, 2023 at 12:06:17PM -0400, Matthew Howell wrote:
> From: Matthew Howell <matthew.howell@sealevel.com>
> 
> These Sealevel 7xxxC IDs are no longer needed because we (Sealevel) will
> be releasing the cards with the standard Exar hardware IDs. This is due
> to the selected IDs causing unexpected behaviors on some Windows systems.
> 
> Reverts: 14ee78d ("Add support for Sealevel 7xxxC serial cards")

If this is a real "revert", then perhaps just do that revert instead?

Also, as per our documentation, you need a sha1 a bit longer than that
:)

And "Reverts:" isn't a valid tag, perhaps "Fixes:"?

And meta-note, your patch series was not linked together, how did you
send them?

thanks,

greg k-h

Re: [PATCH 1/2] serial: exar: Remove Sealevel 7xxxC IDs

[Matthew Howell]

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

On Mon, 21 Aug 2023, Greg KH wrote:

> ⚠Caution: External email. Exercise extreme caution with links or attachments.⚠
> 
> 
> On Mon, Aug 21, 2023 at 12:06:17PM -0400, Matthew Howell wrote:
> > From: Matthew Howell <matthew.howell@sealevel.com>
> >
> > These Sealevel 7xxxC IDs are no longer needed because we (Sealevel) will
> > be releasing the cards with the standard Exar hardware IDs. This is due
> > to the selected IDs causing unexpected behaviors on some Windows systems.
> >
> > Reverts: 14ee78d ("Add support for Sealevel 7xxxC serial cards")
> 
> If this is a real "revert", then perhaps just do that revert instead?

I will try that if that is preferable.
 
> Also, as per our documentation, you need a sha1 a bit longer than that
> :)

Sorry, I thought I had seen them referenced as 7 characters in other 
posts. Will fix when I resubmit.

> 
> And "Reverts:" isn't a valid tag, perhaps "Fixes:"?
> 
> And meta-note, your patch series was not linked together, how did you
> send them?

I used Alpine. 
Sorry for the hassle...but could you clarify how they should be linked? Do 
you mean I should have sent the second patch as a reply to this one? 
I didn't see any specifics about patch linking in the documentation so I 
am not/was not clear on the intended or 'best practice' way of linking 
patches.

> 
> thanks,
> 
> greg k-h
> 

Re: [PATCH 1/2] serial: exar: Remove Sealevel 7xxxC IDs

[Greg KH]

On Mon, Aug 21, 2023 at 03:09:22PM -0400, Matthew Howell wrote:
> On Mon, 21 Aug 2023, Greg KH wrote:
> 
> > ⚠Caution: External email. Exercise extreme caution with links or attachments.⚠
> > 
> > 
> > On Mon, Aug 21, 2023 at 12:06:17PM -0400, Matthew Howell wrote:
> > > From: Matthew Howell <matthew.howell@sealevel.com>
> > >
> > > These Sealevel 7xxxC IDs are no longer needed because we (Sealevel) will
> > > be releasing the cards with the standard Exar hardware IDs. This is due
> > > to the selected IDs causing unexpected behaviors on some Windows systems.
> > >
> > > Reverts: 14ee78d ("Add support for Sealevel 7xxxC serial cards")
> > 
> > If this is a real "revert", then perhaps just do that revert instead?
> 
> I will try that if that is preferable.

It is please.

> > Also, as per our documentation, you need a sha1 a bit longer than that
> > :)
> 
> Sorry, I thought I had seen them referenced as 7 characters in other 
> posts. Will fix when I resubmit.
> 
> > 
> > And "Reverts:" isn't a valid tag, perhaps "Fixes:"?
> > 
> > And meta-note, your patch series was not linked together, how did you
> > send them?
> 
> I used Alpine. 
> Sorry for the hassle...but could you clarify how they should be linked? Do 
> you mean I should have sent the second patch as a reply to this one?

Yes.  That way our tools automatically pick it up as a patch series.

> I didn't see any specifics about patch linking in the documentation so I 
> am not/was not clear on the intended or 'best practice' way of linking 
> patches.

git send-email does it automatically for you, or you have to do it
manually if you don't use that, sorry.

thanks,

greg k-h