From: Greg KH <gregkh@linuxfoundation.org>
To: Zijun Hu <quic_zijuhu@quicinc.com>
Cc: jirislaby@kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v1] tty: Make tty-ldisc module loading logic easy to understand
Date: Fri, 15 Dec 2023 13:17:18 +0100 [thread overview]
Message-ID: <2023121502-chewer-alto-dba4@gregkh> (raw)
In-Reply-To: <1702640236-22824-1-git-send-email-quic_zijuhu@quicinc.com>
On Fri, Dec 15, 2023 at 07:37:16PM +0800, Zijun Hu wrote:
> Current tty-ldisc module loading logic within tty_ldisc_get()
> is prone to mislead beginner that the module is able to be loaded
> by a user without capability CAP_SYS_MODULE, add comments and
> optimize the logic to make it easy to undertand.
You did not "optimize" anything here, you just:
> - if (!capable(CAP_SYS_MODULE) && !tty_ldisc_autoload)
> + if (!tty_ldisc_autoload && !capable(CAP_SYS_MODULE))
Switched the operands around, not really doing anything at all to make
it "easier" to understand, sorry.
Again, please go work with developers at:
> The Qualcomm Innovation Center
To come up with a better change and get them to sign-off on the change
before resubmitting it to us for review.
thanks,
greg k-h
next prev parent reply other threads:[~2023-12-15 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 11:37 [PATCH v1] tty: Make tty-ldisc module loading logic easy to understand Zijun Hu
2023-12-15 12:17 ` Greg KH [this message]
2023-12-15 13:24 ` quic_zijuhu
2023-12-15 13:41 ` [PATCH v2] tty: Add comments for tty-ldisc module loading logic Zijun Hu
2023-12-15 14:12 ` Greg KH
2023-12-15 14:58 ` quic_zijuhu
2023-12-15 14:19 ` Vijaya Krishna Nivarthi
2023-12-15 17:26 ` Jiri Slaby
2023-12-15 17:51 ` Elliot Berman
2023-12-16 4:04 ` quic_zijuhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023121502-chewer-alto-dba4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox