Re: [PATCH v1] tty: Make tty-ldisc module loading logic easy to understand

[quic_zijuhu <quic_zijuhu@quicinc.com>]

On 12/15/2023 8:17 PM, Greg KH wrote:
> On Fri, Dec 15, 2023 at 07:37:16PM +0800, Zijun Hu wrote:
>> Current tty-ldisc module loading logic within tty_ldisc_get()
>> is prone to mislead beginner that the module is able to be loaded
>> by a user without capability CAP_SYS_MODULE, add comments and
>> optimize the logic to make it easy to undertand.
> 
> You did not "optimize" anything here, you just:
> 
>> -		if (!capable(CAP_SYS_MODULE) && !tty_ldisc_autoload)
>> +		if (!tty_ldisc_autoload && !capable(CAP_SYS_MODULE))
> 
> Switched the operands around, not really doing anything at all to make
> it "easier" to understand, sorry.
> 
will remove it and only add comments.
> Again, please go work with developers at:
> 
>> The Qualcomm Innovation Center
> 
> To come up with a better change and get them to sign-off on the change
> before resubmitting it to us for review.
> 
i doesn't belong to uart team and i just need to use tty so learn it.
i will also send it to quicinc guys extracted from tty commit history for code review from them.
> thanks,
> 
> greg k-h