* [PATCH v1] serial: 8250_lpss: copy dma_param using devm_kmemdup()
@ 2024-01-02 5:50 Raag Jadav
2024-01-02 10:33 ` Ilpo Järvinen
2024-01-02 12:05 ` Mika Westerberg
0 siblings, 2 replies; 3+ messages in thread
From: Raag Jadav @ 2024-01-02 5:50 UTC (permalink / raw)
To: ilpo.jarvinen, mika.westerberg, andriy.shevchenko, gregkh,
jirislaby
Cc: linux-kernel, linux-serial, Raag Jadav
Use devm_kmemdup() helper to copy dma_param instead of doing it manually.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/tty/serial/8250/8250_lpss.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
index 0e43bdfb7459..776ec1ef29d6 100644
--- a/drivers/tty/serial/8250/8250_lpss.c
+++ b/drivers/tty/serial/8250/8250_lpss.c
@@ -287,17 +287,14 @@ static int lpss8250_dma_setup(struct lpss8250 *lpss, struct uart_8250_port *port
return 0;
}
- rx_param = devm_kzalloc(dev, sizeof(*rx_param), GFP_KERNEL);
+ rx_param = devm_kmemdup(dev, &lpss->dma_param, sizeof(*rx_param), GFP_KERNEL);
if (!rx_param)
return -ENOMEM;
- tx_param = devm_kzalloc(dev, sizeof(*tx_param), GFP_KERNEL);
+ tx_param = devm_kmemdup(dev, &lpss->dma_param, sizeof(*tx_param), GFP_KERNEL);
if (!tx_param)
return -ENOMEM;
- *rx_param = lpss->dma_param;
- *tx_param = lpss->dma_param;
-
dma->fn = lpss8250_dma_filter;
dma->rx_param = rx_param;
dma->tx_param = tx_param;
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] serial: 8250_lpss: copy dma_param using devm_kmemdup()
2024-01-02 5:50 [PATCH v1] serial: 8250_lpss: copy dma_param using devm_kmemdup() Raag Jadav
@ 2024-01-02 10:33 ` Ilpo Järvinen
2024-01-02 12:05 ` Mika Westerberg
1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2024-01-02 10:33 UTC (permalink / raw)
To: Raag Jadav
Cc: Mika Westerberg, Andy Shevchenko, Greg Kroah-Hartman, Jiri Slaby,
LKML, linux-serial
[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]
On Tue, 2 Jan 2024, Raag Jadav wrote:
> Use devm_kmemdup() helper to copy dma_param instead of doing it manually.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
> drivers/tty/serial/8250/8250_lpss.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
> index 0e43bdfb7459..776ec1ef29d6 100644
> --- a/drivers/tty/serial/8250/8250_lpss.c
> +++ b/drivers/tty/serial/8250/8250_lpss.c
> @@ -287,17 +287,14 @@ static int lpss8250_dma_setup(struct lpss8250 *lpss, struct uart_8250_port *port
> return 0;
> }
>
> - rx_param = devm_kzalloc(dev, sizeof(*rx_param), GFP_KERNEL);
> + rx_param = devm_kmemdup(dev, &lpss->dma_param, sizeof(*rx_param), GFP_KERNEL);
> if (!rx_param)
> return -ENOMEM;
>
> - tx_param = devm_kzalloc(dev, sizeof(*tx_param), GFP_KERNEL);
> + tx_param = devm_kmemdup(dev, &lpss->dma_param, sizeof(*tx_param), GFP_KERNEL);
> if (!tx_param)
> return -ENOMEM;
>
> - *rx_param = lpss->dma_param;
> - *tx_param = lpss->dma_param;
> -
> dma->fn = lpss8250_dma_filter;
> dma->rx_param = rx_param;
> dma->tx_param = tx_param;
>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] serial: 8250_lpss: copy dma_param using devm_kmemdup()
2024-01-02 5:50 [PATCH v1] serial: 8250_lpss: copy dma_param using devm_kmemdup() Raag Jadav
2024-01-02 10:33 ` Ilpo Järvinen
@ 2024-01-02 12:05 ` Mika Westerberg
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2024-01-02 12:05 UTC (permalink / raw)
To: Raag Jadav
Cc: ilpo.jarvinen, andriy.shevchenko, gregkh, jirislaby, linux-kernel,
linux-serial
On Tue, Jan 02, 2024 at 11:20:06AM +0530, Raag Jadav wrote:
> Use devm_kmemdup() helper to copy dma_param instead of doing it manually.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-02 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-02 5:50 [PATCH v1] serial: 8250_lpss: copy dma_param using devm_kmemdup() Raag Jadav
2024-01-02 10:33 ` Ilpo Järvinen
2024-01-02 12:05 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox