* [PATCH] tty: serial: Fix bit order in RS485 flag definitions
@ 2024-01-18 12:43 Christoph Niedermaier
2024-01-18 14:18 ` Greg Kroah-Hartman
2024-01-18 15:00 ` Hugo Villeneuve
0 siblings, 2 replies; 5+ messages in thread
From: Christoph Niedermaier @ 2024-01-18 12:43 UTC (permalink / raw)
To: linux-serial, linux-arm-kernel
Cc: Christoph Niedermaier, Greg Kroah-Hartman, Crescent CY Hsieh,
Jiri Slaby, Lukas Wunner, Lino Sanfilippo
Since the commit 93f3350c46fa ("RS485: fix inconsistencies in the
meaning of some variables"), the definition for bit 3 has been removed.
But with the switch to bit shift marcos in commit 76ac8e29855b ("tty:
serial: Cleanup the bit shift with macro"), this gap wasn't preserved.
To avoid a break in user/kernel api of the system skip bit 3 again and
add a placeholder comment.
Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
---
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Lino Sanfilippo <l.sanfilippo@kunbus.com>
To: linux-serial@vger.kernel.org
To: linux-arm-kernel@lists.infradead.org
---
include/uapi/linux/serial.h | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/include/uapi/linux/serial.h b/include/uapi/linux/serial.h
index 9086367db043..de9b4733607e 100644
--- a/include/uapi/linux/serial.h
+++ b/include/uapi/linux/serial.h
@@ -145,12 +145,13 @@ struct serial_rs485 {
#define SER_RS485_ENABLED _BITUL(0)
#define SER_RS485_RTS_ON_SEND _BITUL(1)
#define SER_RS485_RTS_AFTER_SEND _BITUL(2)
-#define SER_RS485_RX_DURING_TX _BITUL(3)
-#define SER_RS485_TERMINATE_BUS _BITUL(4)
-#define SER_RS485_ADDRB _BITUL(5)
-#define SER_RS485_ADDR_RECV _BITUL(6)
-#define SER_RS485_ADDR_DEST _BITUL(7)
-#define SER_RS485_MODE_RS422 _BITUL(8)
+/* Placeholder for bit 3: SER_RS485_RTS_BEFORE_SEND, which isn't used anymore */
+#define SER_RS485_RX_DURING_TX _BITUL(4)
+#define SER_RS485_TERMINATE_BUS _BITUL(5)
+#define SER_RS485_ADDRB _BITUL(6)
+#define SER_RS485_ADDR_RECV _BITUL(7)
+#define SER_RS485_ADDR_DEST _BITUL(8)
+#define SER_RS485_MODE_RS422 _BITUL(9)
__u32 delay_rts_before_send;
__u32 delay_rts_after_send;
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] tty: serial: Fix bit order in RS485 flag definitions
2024-01-18 12:43 [PATCH] tty: serial: Fix bit order in RS485 flag definitions Christoph Niedermaier
@ 2024-01-18 14:18 ` Greg Kroah-Hartman
2024-01-18 15:42 ` Christoph Niedermaier
2024-01-18 15:00 ` Hugo Villeneuve
1 sibling, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2024-01-18 14:18 UTC (permalink / raw)
To: Christoph Niedermaier
Cc: linux-serial, linux-arm-kernel, Crescent CY Hsieh, Jiri Slaby,
Lukas Wunner, Lino Sanfilippo
On Thu, Jan 18, 2024 at 01:43:50PM +0100, Christoph Niedermaier wrote:
> Since the commit 93f3350c46fa ("RS485: fix inconsistencies in the
> meaning of some variables"), the definition for bit 3 has been removed.
> But with the switch to bit shift marcos in commit 76ac8e29855b ("tty:
> serial: Cleanup the bit shift with macro"), this gap wasn't preserved.
> To avoid a break in user/kernel api of the system skip bit 3 again and
> add a placeholder comment.
>
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> ---
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: Lukas Wunner <lukas@wunner.de>
> Cc: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> To: linux-serial@vger.kernel.org
> To: linux-arm-kernel@lists.infradead.org
> ---
Shouldn't this have a Fixes: tag in it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] tty: serial: Fix bit order in RS485 flag definitions
2024-01-18 14:18 ` Greg Kroah-Hartman
@ 2024-01-18 15:42 ` Christoph Niedermaier
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Niedermaier @ 2024-01-18 15:42 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Crescent CY Hsieh,
Jiri Slaby, Lukas Wunner, Lino Sanfilippo
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Thursday, January 18, 2024 3:19 PM
> On Thu, Jan 18, 2024 at 01:43:50PM +0100, Christoph Niedermaier wrote:
>> Since the commit 93f3350c46fa ("RS485: fix inconsistencies in the
>> meaning of some variables"), the definition for bit 3 has been removed.
>> But with the switch to bit shift marcos in commit 76ac8e29855b ("tty:
>> serial: Cleanup the bit shift with macro"), this gap wasn't preserved.
>> To avoid a break in user/kernel api of the system skip bit 3 again and
>> add a placeholder comment.
>>
>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
>> ---
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
>> Cc: Jiri Slaby <jirislaby@kernel.org>
>> Cc: Lukas Wunner <lukas@wunner.de>
>> Cc: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>> To: linux-serial@vger.kernel.org
>> To: linux-arm-kernel@lists.infradead.org
>> ---
>
> Shouldn't this have a Fixes: tag in it?
I will fix that in Version 2.
Regards
Christoph
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tty: serial: Fix bit order in RS485 flag definitions
2024-01-18 12:43 [PATCH] tty: serial: Fix bit order in RS485 flag definitions Christoph Niedermaier
2024-01-18 14:18 ` Greg Kroah-Hartman
@ 2024-01-18 15:00 ` Hugo Villeneuve
2024-01-18 15:43 ` Christoph Niedermaier
1 sibling, 1 reply; 5+ messages in thread
From: Hugo Villeneuve @ 2024-01-18 15:00 UTC (permalink / raw)
To: Christoph Niedermaier
Cc: linux-serial, linux-arm-kernel, Greg Kroah-Hartman,
Crescent CY Hsieh, Jiri Slaby, Lukas Wunner, Lino Sanfilippo
On Thu, 18 Jan 2024 13:43:50 +0100
Christoph Niedermaier <cniedermaier@dh-electronics.com> wrote:
> Since the commit 93f3350c46fa ("RS485: fix inconsistencies in the
> meaning of some variables"), the definition for bit 3 has been removed.
> But with the switch to bit shift marcos in commit 76ac8e29855b ("tty:
marcos -> macros
Hugo Villeneuve
> serial: Cleanup the bit shift with macro"), this gap wasn't preserved.
> To avoid a break in user/kernel api of the system skip bit 3 again and
> add a placeholder comment.
>
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> ---
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: Lukas Wunner <lukas@wunner.de>
> Cc: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> To: linux-serial@vger.kernel.org
> To: linux-arm-kernel@lists.infradead.org
> ---
> include/uapi/linux/serial.h | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/include/uapi/linux/serial.h b/include/uapi/linux/serial.h
> index 9086367db043..de9b4733607e 100644
> --- a/include/uapi/linux/serial.h
> +++ b/include/uapi/linux/serial.h
> @@ -145,12 +145,13 @@ struct serial_rs485 {
> #define SER_RS485_ENABLED _BITUL(0)
> #define SER_RS485_RTS_ON_SEND _BITUL(1)
> #define SER_RS485_RTS_AFTER_SEND _BITUL(2)
> -#define SER_RS485_RX_DURING_TX _BITUL(3)
> -#define SER_RS485_TERMINATE_BUS _BITUL(4)
> -#define SER_RS485_ADDRB _BITUL(5)
> -#define SER_RS485_ADDR_RECV _BITUL(6)
> -#define SER_RS485_ADDR_DEST _BITUL(7)
> -#define SER_RS485_MODE_RS422 _BITUL(8)
> +/* Placeholder for bit 3: SER_RS485_RTS_BEFORE_SEND, which isn't used anymore */
> +#define SER_RS485_RX_DURING_TX _BITUL(4)
> +#define SER_RS485_TERMINATE_BUS _BITUL(5)
> +#define SER_RS485_ADDRB _BITUL(6)
> +#define SER_RS485_ADDR_RECV _BITUL(7)
> +#define SER_RS485_ADDR_DEST _BITUL(8)
> +#define SER_RS485_MODE_RS422 _BITUL(9)
>
> __u32 delay_rts_before_send;
> __u32 delay_rts_after_send;
> --
> 2.11.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] tty: serial: Fix bit order in RS485 flag definitions
2024-01-18 15:00 ` Hugo Villeneuve
@ 2024-01-18 15:43 ` Christoph Niedermaier
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Niedermaier @ 2024-01-18 15:43 UTC (permalink / raw)
To: Hugo Villeneuve
Cc: linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman,
Crescent CY Hsieh, Jiri Slaby, Lukas Wunner, Lino Sanfilippo
From: Hugo Villeneuve <hugo@hugovil.com>
Sent: Thursday, January 18, 2024 4:01 PM
> On Thu, 18 Jan 2024 13:43:50 +0100
> Christoph Niedermaier <cniedermaier@dh-electronics.com> wrote:
>
>> Since the commit 93f3350c46fa ("RS485: fix inconsistencies in the
>> meaning of some variables"), the definition for bit 3 has been removed.
>> But with the switch to bit shift marcos in commit 76ac8e29855b ("tty:
>
> marcos -> macros
>
I will fix that in Version 2.
[...]
Regards
Christoph
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-18 15:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-18 12:43 [PATCH] tty: serial: Fix bit order in RS485 flag definitions Christoph Niedermaier
2024-01-18 14:18 ` Greg Kroah-Hartman
2024-01-18 15:42 ` Christoph Niedermaier
2024-01-18 15:00 ` Hugo Villeneuve
2024-01-18 15:43 ` Christoph Niedermaier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox