* speed_t usage?
@ 2024-03-13 11:50 Andy Shevchenko
2024-04-09 13:36 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2024-03-13 11:50 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby; +Cc: linux-serial, Ilpo Järvinen
Hi!
Recently while doing some serial driver cleanup I realised that TTY uses
speed_t type for baud rates. What is the appropriate use of it?
Either it is going to be killed (replaced with POD), or should / may we
spread it over tty/serial and further?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: speed_t usage?
2024-03-13 11:50 speed_t usage? Andy Shevchenko
@ 2024-04-09 13:36 ` Greg Kroah-Hartman
2024-04-09 13:43 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2024-04-09 13:36 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Jiri Slaby, linux-serial, Ilpo Järvinen
On Wed, Mar 13, 2024 at 01:50:56PM +0200, Andy Shevchenko wrote:
> Hi!
>
> Recently while doing some serial driver cleanup I realised that TTY uses
> speed_t type for baud rates. What is the appropriate use of it?
> Either it is going to be killed (replaced with POD), or should / may we
> spread it over tty/serial and further?
As it's a uapi interface we can't just delete it entirely, but please,
do not spread it any further, and try to clean up what places in the
kernel itself that we can to use a "real" type that we know the size of
at all times (i.e. u32/u64), not just having to guess like we do today.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: speed_t usage?
2024-04-09 13:36 ` Greg Kroah-Hartman
@ 2024-04-09 13:43 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-04-09 13:43 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jiri Slaby, linux-serial, Ilpo Järvinen
On Tue, Apr 09, 2024 at 03:36:11PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Mar 13, 2024 at 01:50:56PM +0200, Andy Shevchenko wrote:
> > Hi!
> >
> > Recently while doing some serial driver cleanup I realised that TTY uses
> > speed_t type for baud rates. What is the appropriate use of it?
> > Either it is going to be killed (replaced with POD), or should / may we
> > spread it over tty/serial and further?
>
> As it's a uapi interface we can't just delete it entirely, but please,
> do not spread it any further, and try to clean up what places in the
> kernel itself that we can to use a "real" type that we know the size of
> at all times (i.e. u32/u64), not just having to guess like we do today.
Thank you for clarification!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-09 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-13 11:50 speed_t usage? Andy Shevchenko
2024-04-09 13:36 ` Greg Kroah-Hartman
2024-04-09 13:43 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox