From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Raul E Rangel <rrangel@chromium.org>
Cc: linux-serial@vger.kernel.org, pmladek@suse.com,
rafael.j.wysocki@intel.com, ribalda@chromium.org,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] earlycon: Print a notice when uartclk is unknown
Date: Fri, 13 Sep 2024 07:57:48 +0200 [thread overview]
Message-ID: <2024091340-tacky-everybody-b582@gregkh> (raw)
In-Reply-To: <20240912113616.2.Id2235082fc6c2d238789dfc3ee923492e9ed7387@changeid>
On Thu, Sep 12, 2024 at 11:36:20AM -0600, Raul E Rangel wrote:
> When trying to construct an earlycon=uart parameter it's hard to debug
> why it's not working. In my specific case it was because the default
> uartclk earlycon assumes doesn't match my hardware. This change adds a
> notice so that the user is made aware of that this assumption is being
> made. This should hopefully lead to them adding a <uartclk> option to
> their earlycon parameter.
>
> Booting with `console=uart,mmio32,0xfedc9000,115200n8`:
> [ 0.000000] earlycon: uart: Unknown uartclk, assuming 1843200hz
> [ 0.000000] earlycon: uart0 at MMIO32 0x00000000fedc9000 (options '115200n8')
>
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2024-09-13 5:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 17:36 [PATCH 0/3] Implement ACPI SPCR v3 support and minor earlycon cleanup Raul E Rangel
2024-09-12 17:36 ` [PATCH 1/3] Documentation: kernel-parameters: Add uartclk to console=uart Raul E Rangel
2024-09-13 15:18 ` Petr Mladek
2024-09-12 17:36 ` [PATCH 2/3] earlycon: Print a notice when uartclk is unknown Raul E Rangel
2024-09-13 5:57 ` Greg Kroah-Hartman [this message]
2024-09-13 15:35 ` Petr Mladek
2024-09-12 17:36 ` [PATCH 3/3] ACPI: SPCR: Add support for rev 3 Raul E Rangel
2024-09-13 15:43 ` Petr Mladek
2024-10-02 18:13 ` Rafael J. Wysocki
2024-10-04 17:45 ` Raul Rangel
2024-10-04 17:54 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024091340-tacky-everybody-b582@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ribalda@chromium.org \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox