From: Petr Mladek <pmladek@suse.com>
To: Raul E Rangel <rrangel@chromium.org>
Cc: linux-serial@vger.kernel.org, rafael.j.wysocki@intel.com,
ribalda@chromium.org, Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Robert Moore <robert.moore@intel.com>,
acpica-devel@lists.linux.dev, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ACPI: SPCR: Add support for rev 3
Date: Fri, 13 Sep 2024 17:43:48 +0200 [thread overview]
Message-ID: <ZuRdtFNjFr1_-VEw@pathway.suse.cz> (raw)
In-Reply-To: <20240912113616.3.I1b7a5033a2191cb0cdbadc2d51666a97f16cc663@changeid>
On Thu 2024-09-12 11:36:21, Raul E Rangel wrote:
> Revision 3 supports specifying the UART input clock. This allows for
> proper computation of the UART divisor when the baud rate is specified.
>
> The earlycon code can accept the following format (See `parse_options`
> in `earlycon.c`.):
> * <name>,io|mmio|mmio32|mmio32be,<addr>,<baud>,<uartclk>,<options>
>
> This change makes it so the uartclk is passed along if it's defined in
> the SPCR table.
>
> Booting with `earlycon` and a SPCR v3 table that has the uartclk and
> baud defined:
> [ 0.028251] ACPI: SPCR: console: uart,mmio32,0xfedc9000,115200,48000000
> [ 0.028267] earlycon: uart0 at MMIO32 0x00000000fedc9000 (options '115200,48000000')
> [ 0.028272] printk: legacy bootconsole [uart0] enabled
>
> Link: https://learn.microsoft.com/en-us/windows-hardware/drivers/serports/serial-port-console-redirection-table
>
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Looks good to me:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2024-09-13 15:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 17:36 [PATCH 0/3] Implement ACPI SPCR v3 support and minor earlycon cleanup Raul E Rangel
2024-09-12 17:36 ` [PATCH 1/3] Documentation: kernel-parameters: Add uartclk to console=uart Raul E Rangel
2024-09-13 15:18 ` Petr Mladek
2024-09-12 17:36 ` [PATCH 2/3] earlycon: Print a notice when uartclk is unknown Raul E Rangel
2024-09-13 5:57 ` Greg Kroah-Hartman
2024-09-13 15:35 ` Petr Mladek
2024-09-12 17:36 ` [PATCH 3/3] ACPI: SPCR: Add support for rev 3 Raul E Rangel
2024-09-13 15:43 ` Petr Mladek [this message]
2024-10-02 18:13 ` Rafael J. Wysocki
2024-10-04 17:45 ` Raul Rangel
2024-10-04 17:54 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuRdtFNjFr1_-VEw@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=acpica-devel@lists.linux.dev \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=ribalda@chromium.org \
--cc=robert.moore@intel.com \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox