* [PATCH] tty: serial: export serial_8250_warn_need_ioport
@ 2024-10-29 15:27 Arnd Bergmann
2024-10-29 16:14 ` Niklas Schnelle
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-10-29 15:27 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Arnd Bergmann, Niklas Schnelle,
Maciej W. Rozycki
Cc: Arnd Bergmann, Jeff Johnson, linux-kernel, linux-serial
From: Arnd Bergmann <arnd@arndb.de>
The newly added function is used from a loadable module, so it has
to be exported the same way as the other function in this file:
ERROR: modpost: "serial_8250_warn_need_ioport" [drivers/tty/serial/8250/8250_pci.ko] undefined!
Fixes: 7c7e6c8924e7 ("tty: serial: handle HAS_IOPORT dependencies")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
The build regression is currently part of my asm-generic tree, so I've
applied this fixup on top.
drivers/tty/serial/8250/8250_pcilib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/8250/8250_pcilib.c b/drivers/tty/serial/8250/8250_pcilib.c
index ec4d04177802..3bdccf76f71d 100644
--- a/drivers/tty/serial/8250/8250_pcilib.c
+++ b/drivers/tty/serial/8250/8250_pcilib.c
@@ -19,6 +19,7 @@ int serial_8250_warn_need_ioport(struct pci_dev *dev)
return -ENXIO;
}
+EXPORT_SYMBOL_NS_GPL(serial_8250_warn_need_ioport, SERIAL_8250_PCI);
int serial8250_pci_setup_port(struct pci_dev *dev, struct uart_8250_port *port,
u8 bar, unsigned int offset, int regshift)
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tty: serial: export serial_8250_warn_need_ioport
2024-10-29 15:27 [PATCH] tty: serial: export serial_8250_warn_need_ioport Arnd Bergmann
@ 2024-10-29 16:14 ` Niklas Schnelle
0 siblings, 0 replies; 2+ messages in thread
From: Niklas Schnelle @ 2024-10-29 16:14 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman, Jiri Slaby, Maciej W. Rozycki
Cc: Arnd Bergmann, Jeff Johnson, linux-kernel, linux-serial
On Tue, 2024-10-29 at 15:27 +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added function is used from a loadable module, so it has
> to be exported the same way as the other function in this file:
>
> ERROR: modpost: "serial_8250_warn_need_ioport" [drivers/tty/serial/8250/8250_pci.ko] undefined!
>
> Fixes: 7c7e6c8924e7 ("tty: serial: handle HAS_IOPORT dependencies")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> The build regression is currently part of my asm-generic tree, so I've
> applied this fixup on top.
>
> drivers/tty/serial/8250/8250_pcilib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/8250/8250_pcilib.c b/drivers/tty/serial/8250/8250_pcilib.c
> index ec4d04177802..3bdccf76f71d 100644
> --- a/drivers/tty/serial/8250/8250_pcilib.c
> +++ b/drivers/tty/serial/8250/8250_pcilib.c
> @@ -19,6 +19,7 @@ int serial_8250_warn_need_ioport(struct pci_dev *dev)
>
> return -ENXIO;
> }
> +EXPORT_SYMBOL_NS_GPL(serial_8250_warn_need_ioport, SERIAL_8250_PCI);
>
> int serial8250_pci_setup_port(struct pci_dev *dev, struct uart_8250_port *port,
> u8 bar, unsigned int offset, int regshift)
Looks like I forgot to try the last version plus the temporarily
removed !S390 with allmodconfig instead of allyesconfig.
Thanks for the fix!
Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-29 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-29 15:27 [PATCH] tty: serial: export serial_8250_warn_need_ioport Arnd Bergmann
2024-10-29 16:14 ` Niklas Schnelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox