[PATCH] tty/sysrq: make sysrq_replay_logs_op const

[PATCH] tty/sysrq: make sysrq_replay_logs_op const

[xiaopeitux]

From: Pei Xiao <xiaopei01@kylinos.cn>

Mark sysrq_replay_logs_op as const, preventing accidental modification.

Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
 drivers/tty/sysrq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index f85ce02e4725..e9ada1c14e26 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -454,7 +454,7 @@ static void sysrq_handle_replay_logs(u8 key)
 {
 	console_try_replay_all();
 }
-static struct sysrq_key_op sysrq_replay_logs_op = {
+static const struct sysrq_key_op sysrq_replay_logs_op = {
 	.handler        = sysrq_handle_replay_logs,
 	.help_msg       = "replay-kernel-logs(R)",
 	.action_msg     = "Replay kernel logs on consoles",
-- 
2.25.1

Re: [PATCH] tty/sysrq: make sysrq_replay_logs_op const

[Greg KH]

On Thu, Apr 03, 2025 at 04:38:18PM +0800, xiaopeitux@foxmail.com wrote:
> From: Pei Xiao <xiaopei01@kylinos.cn>
> 
> Mark sysrq_replay_logs_op as const, preventing accidental modification.
> 
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
>  drivers/tty/sysrq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index f85ce02e4725..e9ada1c14e26 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -454,7 +454,7 @@ static void sysrq_handle_replay_logs(u8 key)
>  {
>  	console_try_replay_all();
>  }
> -static struct sysrq_key_op sysrq_replay_logs_op = {
> +static const struct sysrq_key_op sysrq_replay_logs_op = {
>  	.handler        = sysrq_handle_replay_logs,
>  	.help_msg       = "replay-kernel-logs(R)",
>  	.action_msg     = "Replay kernel logs on consoles",
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] tty/sysrq: make sysrq_replay_logs_op const

[Pei Xiao]

在 2025/4/3 16:38, xiaopeitux@foxmail.com 写道:

> From: Pei Xiao <xiaopei01@kylinos.cn>
>
> Mark sysrq_replay_logs_op as const, preventing accidental modification.
>
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
>  drivers/tty/sysrq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index f85ce02e4725..e9ada1c14e26 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -454,7 +454,7 @@ static void sysrq_handle_replay_logs(u8 key)
>  {
>  	console_try_replay_all();
>  }
> -static struct sysrq_key_op sysrq_replay_logs_op = {
> +static const struct sysrq_key_op sysrq_replay_logs_op = {
>  	.handler        = sysrq_handle_replay_logs,
>  	.help_msg       = "replay-kernel-logs(R)",
>  	.action_msg     = "Replay kernel logs on consoles",

now, split into a single patch.

Thanks!

Pei.