* [PATCH v2] selftests: tty: add tty_tiocsti_test to .gitignore [not found] <2025102633-dandruff-clang-e91d@gregkh> @ 2025-10-26 9:22 ` Gopi Krishna Menon 2025-10-26 9:35 ` Greg KH 0 siblings, 1 reply; 3+ messages in thread From: Gopi Krishna Menon @ 2025-10-26 9:22 UTC (permalink / raw) To: gregkh, jirislaby Cc: Gopi Krishna Menon, linux-kselftest, linux-kernel, linux-serial, david.hunter.linux, xandfury, skhan, linux-kernel-mentees, khalid Building the tty selftests generates the tty_tiocsti_test binary, which appears as untracked file in git. As mentioned in the kselftest documentation, all the generated objects must be placed inside .gitignore. This prevents the generated objects from accidentally getting staged and keeps the working tree clean. Add the tty_tiocsti_test binary to .gitignore to avoid accidentally staging the build artifact and maintain a clean working tree. Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details Suggested-by: David Hunter <david.hunter.linux@gmail.com> Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com> --- Changelog: - Improve the commit wording and explain clearly why this change is needed. tools/testing/selftests/tty/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore index fe70462a4aad..2453685d2493 100644 --- a/tools/testing/selftests/tty/.gitignore +++ b/tools/testing/selftests/tty/.gitignore @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only +tty_tiocsti_test tty_tstamp_update -- 2.43.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] selftests: tty: add tty_tiocsti_test to .gitignore 2025-10-26 9:22 ` [PATCH v2] selftests: tty: add tty_tiocsti_test to .gitignore Gopi Krishna Menon @ 2025-10-26 9:35 ` Greg KH 2025-10-26 10:00 ` [PATCH v3] " Gopi Krishna Menon 0 siblings, 1 reply; 3+ messages in thread From: Greg KH @ 2025-10-26 9:35 UTC (permalink / raw) To: Gopi Krishna Menon Cc: jirislaby, linux-kselftest, linux-kernel, linux-serial, david.hunter.linux, xandfury, skhan, linux-kernel-mentees, khalid On Sun, Oct 26, 2025 at 02:52:32PM +0530, Gopi Krishna Menon wrote: > Building the tty selftests generates the tty_tiocsti_test binary, which > appears as untracked file in git. As mentioned in the kselftest > documentation, all the generated objects must be placed inside > .gitignore. This prevents the generated objects from accidentally > getting staged and keeps the working tree clean. > > Add the tty_tiocsti_test binary to .gitignore to avoid accidentally > staging the build artifact and maintain a clean working tree. > > Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details > > Suggested-by: David Hunter <david.hunter.linux@gmail.com> > Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com> > --- > Changelog: > - Improve the commit wording and explain clearly why this change is needed. What commit id does this fix? thanks, greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3] selftests: tty: add tty_tiocsti_test to .gitignore 2025-10-26 9:35 ` Greg KH @ 2025-10-26 10:00 ` Gopi Krishna Menon 0 siblings, 0 replies; 3+ messages in thread From: Gopi Krishna Menon @ 2025-10-26 10:00 UTC (permalink / raw) To: gregkh, jirislaby Cc: Gopi Krishna Menon, linux-kselftest, linux-kernel, linux-serial, david.hunter.linux, xandfury, skhan, linux-kernel-mentees, khalid Building the tty selftests generates the tty_tiocsti_test binary, which appears as untracked file in git. As mentioned in the kselftest documentation, all the generated objects must be placed inside .gitignore. This prevents the generated objects from accidentally getting staged and keeps the working tree clean. Add the tty_tiocsti_test binary to .gitignore to avoid accidentally staging the build artifact and maintain a clean working tree. Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details Fixes: 7553f5173ec3 ("selftests/tty: add TIOCSTI test suite") Suggested-by: Greg KH <gregkh@linuxfoundation.org> Suggested-by: David Hunter <david.hunter.linux@gmail.com> Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com> --- Changelog: v3: - Add fixes tag as suggested by Greg KH. v2: - Improve the commit wording and explain clearly why this change is needed. tools/testing/selftests/tty/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore index fe70462a4aad..2453685d2493 100644 --- a/tools/testing/selftests/tty/.gitignore +++ b/tools/testing/selftests/tty/.gitignore @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only +tty_tiocsti_test tty_tstamp_update -- 2.43.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-26 10:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <2025102633-dandruff-clang-e91d@gregkh>
2025-10-26 9:22 ` [PATCH v2] selftests: tty: add tty_tiocsti_test to .gitignore Gopi Krishna Menon
2025-10-26 9:35 ` Greg KH
2025-10-26 10:00 ` [PATCH v3] " Gopi Krishna Menon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox